Migrate the OpenID module to OpenIddict 6.0 #16929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinchalet
added
OpenId
don't merge
dependencies
This was referenced Nov 1, 2024
kevinchalet
commented
Nov 3, 2024
| public virtual IAsyncEnumerable<TAuthorization> FindAsync( | ||
| string subject, string client, CancellationToken cancellationToken) | ||
| public virtual async IAsyncEnumerable<TAuthorization> FindAsync( | ||
| string subject, string client, string status, string type, |
There was a problem hiding this comment.
It's not obvious since we're not using nullable annotations here, but these parameters are now nullable in 6.0 preview3 (which gives a lot more flexibility to filter the authorizations/tokens).
kevinchalet
commented
Nov 3, 2024
| public virtual async ValueTask<long> RevokeAsync( | ||
| string subject, string client, string status, string type, CancellationToken cancellationToken) | ||
| { | ||
| Expression<Func<OpenIdAuthorizationIndex, bool>> query = index => true; |
There was a problem hiding this comment.
Not an absolute fan of creating expression trees "manually", but AFAIK, YesSql still doesn't support IQueryable<T>, so this is likely the least horrible option 😅
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenIddict 6.0 is still in preview (see https://github.com/openiddict/openiddict-core/releases/tag/6.0.0-preview1 and https://github.com/openiddict/openiddict-core/releases/tag/6.0.0-preview2) but sending a PR early is always a great way to proactively detect potential regressions that may eventually affect Orchard 😃
Note: 6.0 RTM will ship in December.