Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6986 Created feature Media Processing Html Filter #6992

Closed
wants to merge 1 commit into from

Conversation

anoordende
Copy link
Contributor

@anoordende anoordende commented Jun 22, 2016

Fixes #6986

Enabling this feature registers an implementation of IHtmlFilter that works on any part with a flavor of "HTML" that injects and applies the registered IHtmlFilters.

Additional settings appear under in the Admin UI under Settings > Media to control to behavior of this feature. It is quite straightforward:

Density Threshold
With a threshold of, for example, @2x, an image will only be reduced if the natural size of the image is more than 2x the size specified in the attributes.

Quality
Only applies to jpeg's, the quality to compress the image at.

Populate Empty Alt Tags
If the img has an empty Alt tag, one will be composed based on the image file name

noresize attribute
Adding a noresize attribute to any img element will cause the element not to be processed:

<img noresize src="/Media/example.jpg" alt="this image will not be processed" />

_Note that images already the result of a profile (ie already under /Profiles/*) will not be processed.

To try out this feature, simply add a suitable image from your media library to e.g. a body part and use the handles in the editor the resize the image. When rendered, you will see that the image comes from a profile and not from the original source. Change the quality or density in the settings and you will see new profiles being generated.

Clean up the dynamic test profiles or force regeneration with the "Purge Obsolete" feature from PR #6984.

@sebastienros
Copy link
Member

I would not use HtmlAgilityPack. It seems too heavy for the goal here, probably a compiled Regex or a custom parser would be able to fetch all images. Just thinking about performance here.

@sebastienros
Copy link
Member

Unless someone proves a regex wouldn't be optimal for this case.

@BenedekFarkas
Copy link
Member

Note: #6938 has breaking changes.

@BenedekFarkas
Copy link
Member

Closing due to inactivity, superseded by #8806.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Dynamically Media-process images with fixed size in HTML
5 participants