feat: add color tokens

[paulinea]

No description provided.

[github-actions]

🟢 Netlify deploy for commit f6ee355 succeeded

Deploy preview: https://671be390214aef9d557d3af0--ouds-android.netlify.app
Deploy log: https://app.netlify.com/sites/ouds-android/deploys/671be390214aef9d557d3af0

[julien-deramond]

I've modified the parser to generate the OudsColor*SemanticTokens.kt.
I've been able to compare the content of this PR's files and the generated ones.
Great job doing that semi-manually! I've found out only 2 differences that you can find in the comments.

[julien-deramond]

From the parser:

Suggested change

	val gradientSkeletonMiddleOnBgEmphasizedDark: Color = ColorRawTokens.colorFunctionalDarkGray560,
	val gradientSkeletonMiddleOnBgEmphasizedDark: Color = ColorRawTokens.colorFunctionalDarkGray480,

[julien-deramond]

Suggested change

	val gradientSkeletonStartEndOnBgEmphasizedDark: Color = ColorRawTokens.colorFunctionalDarkGray640,
	val gradientSkeletonStartEndOnBgEmphasizedDark: Color = ColorRawTokens.colorFunctionalDarkGray560,

[julien-deramond]

The brand-theme.orange_light.json defines the colors; in the structure of this JSON file, we have:

{
  // ...
  color: {
    action: { //... },
    always: { //... },
    bg: { //... },
    border: { //... },
    brand: { //... },
    chart: { //... },
    content: { //... },
    elevation: { //... },
    gradient: { //... },
    transparent: { //... },
    🎨_decorative: { //... },
  }
  // ...
}

• chart is removed temporarily
• 🎨_decorative will be OudsColorDecorativeSemanticTokens
• For all other keys, we'll uppercase the name to have OudsColor{Key}SemanticTokens

Based on these elements, I'd say that OudsColorGlobalSemanticTokens.kt should rather be OudsColorTransparentSemanticTokens.kt shouldn't it?

[florentmaitre]

There is an issue with the pill radius background because it is not clipped to the border:

Here is the fix:

Suggested change

	IllustrationBox(modifier = modifier, backgroundColor = OudsColorKeyToken.Background.Secondary.value)
	IllustrationBox(modifier = modifier.clip(shape), backgroundColor = OudsColorKeyToken.Background.Secondary.value)

[florentmaitre]

Type is OudsColorKeyToken.Action, which means we cannot set this value to OudsColorKeyToken.Content.Disabled for instance. It seems to me that we should be able to use any semantic color token, am I wrong?

[florentmaitre]

I certainly missed something, but why inverse colors do not appear here?

[florentmaitre]

This class could be an object.

[florentmaitre]

I already added a comment in #147 about adding nested classes to split enum values. This comment is just to remember to apply the changes here if we decide to do so for other tokens.

[florentmaitre]

Should we split negative, primary and secondary parameters into specific objects?

Same question for all nested classes.

[florentmaitre]

We can use with(alwaysColors) to simplify the following lines.

Same comment for other fromToken methods.

[florentmaitre]

Are these final mapping from Maxime? Or is this temporary?

[florentmaitre]

Light value for onSecondaryContainer is contentDefaultDark, should we use contentDefaultLight here?

Same question for onErrorContainer where contentOnStatusNegativeEmphasizedDark is used although the light version is contentOnActionDisabledOnBgEmphasizedLight.

[florentmaitre]

value method for OudsColorKeyToken.Global is missing.