Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSM: fix unintended scroll #899

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Fixes #895.

Description

Remove unnecessary CSS for the embedded page

Motivation & Context

Remove useless scroll on the DSM page > Develop tab.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Checklist

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test on simulators and on a physical device (Android, orientation change, dark/light mode)
  • Code review
  • Design review
  • A11y review

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for ods-android ready!

Name Link
🔨 Latest commit fd22c69
🔍 Latest deploy log https://app.netlify.com/sites/ods-android/deploys/660d5ddf21bb39000812d625
😎 Deploy Preview https://deploy-preview-899--ods-android.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Documentation - Embedded pages in ZeroHeight can contain a vertical scroll bar
1 participant