Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark adding secret variable method as not yet ready to be used. #3466

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Mark adding secret variable method as not yet ready to be used. #3466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/hurl/src/runner/variable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ impl VariableSet {
Ok(())
}

#[deprecated(
note = "This method is not yet ready for use: secret/private variables are still under development"
)]
/// Inserts a secret variable named `name` with `value` into the variable set.
///
/// Contrary to [`VariableSet::insert`], this method can not fail: a secret can override a
Expand Down Expand Up @@ -141,6 +144,7 @@ mod test {
use crate::runner::Number::{Float, Integer};
use crate::runner::{Value, VariableSet};

#[allow(deprecated)]
#[test]
fn simple_variable_set() {
let mut variables = VariableSet::new();
Expand Down Expand Up @@ -203,6 +207,7 @@ mod test {
}
}

#[allow(deprecated)]
#[test]
fn secret_cant_be_reassigned() {
let mut variables = VariableSet::new();
Expand Down
Loading