Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] Grid tokens Bootstrap compatibility (xxl breakpoint) #2761

Merged

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Oct 14, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#2609

Description

Add Bootstrap compatibility to Grid tokens PR #2744

Motivation & Context

xxl breakpoint has been replaced by 2xl. This PR adds the possibility to still use xxl breakpoint with $enable-bootstrap-compatibility=true

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

@hannahiss hannahiss changed the title Ouds/main his tokens grid xxl compat Grid tokens Bootstrap compatibility (xxl breakpoint) Oct 14, 2024
@julien-deramond julien-deramond changed the title Grid tokens Bootstrap compatibility (xxl breakpoint) [OUDS] Grid tokens Bootstrap compatibility (xxl breakpoint) Oct 16, 2024
@julien-deramond julien-deramond added this to the OUDS milestone Oct 16, 2024
…id-xxl-compat

# Conflicts:
#	site/content/docs/0.0/layout/columns.md
@louismaximepiton
Copy link
Member

Just a reminder from #2744, but we shouldn't forget about the $gutters for BS compatibility since they aren't in the utilities.

…id-xxl-compat

# Conflicts:
#	site/content/docs/0.0/migration-from-boosted.md
@hannahiss hannahiss marked this pull request as ready for review October 16, 2024 09:50
…id-xxl-compat

# Conflicts:
#	site/content/docs/0.0/migration-from-boosted.md
@hannahiss hannahiss merged commit 4fdcd73 into ouds/main-his-tokens-grid Oct 18, 2024
4 of 8 checks passed
@hannahiss hannahiss deleted the ouds/main-his-tokens-grid-xxl-compat branch October 18, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants