Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing role='img' #2707

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Missing role='img' #2707

merged 2 commits into from
Sep 12, 2024

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Aug 23, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#2667

Description

Add a role="img" on an informative SGV

Motivation & Context

This issue has been seen while fixing a11y audit.
For accessibility, SVGs having a <title> should also have a role="img"

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 790f1b6
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66e27ab7eeed290008dd978b
😎 Deploy Preview https://deploy-preview-2707--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hannahiss hannahiss added v5 accessibility docs Improvements or additions to documentation labels Aug 23, 2024
@hannahiss hannahiss marked this pull request as ready for review August 23, 2024 14:38
@julien-deramond julien-deramond merged commit 3e20e77 into main Sep 12, 2024
12 checks passed
@julien-deramond julien-deramond deleted the main-his-a11y-missing-role-img branch September 12, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs Improvements or additions to documentation v5
Projects
Development

Successfully merging this pull request may close these issues.

3 participants