Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner for newer version of Boosted #2150

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jul 20, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Add new banner with d-none to ease new version link.

Motivation & Context

Ease process

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is added in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation labels Jul 20, 2023
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit e969898
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64b92af1dd52a400082ab814
😎 Deploy Preview https://deploy-preview-2150--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

site/assets/scss/_sidebar.scss Outdated Show resolved Hide resolved
site/layouts/partials/docs-navbar.html Outdated Show resolved Hide resolved
@julien-deramond julien-deramond self-requested a review July 20, 2023 12:39
@julien-deramond julien-deramond merged commit d0a58a3 into main Jul 20, 2023
12 checks passed
@julien-deramond julien-deramond deleted the main-lmp-new-version-banner branch July 20, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v5
Projects
Development

Successfully merging this pull request may close these issues.

2 participants