Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce problem to check the PR workflows from forks #185

Closed
wants to merge 1 commit into from
Closed

Introduce problem to check the PR workflows from forks #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions json-schema-validator/api/json-schema-validator.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ public final class io/github/optimumcode/json/pointer/JsonPointerKt {
public static final fun JsonPointer (Ljava/lang/String;)Lio/github/optimumcode/json/pointer/JsonPointer;
}

public final class io/github/optimumcode/json/pointer/internal/ExtensionsKt {
public static final fun getLength (Lio/github/optimumcode/json/pointer/JsonPointer;)I
}

public final class io/github/optimumcode/json/schema/AbsoluteLocation {
public static final field Companion Lio/github/optimumcode/json/schema/AbsoluteLocation$Companion;
public fun <init> (Lcom/eygraber/uri/Uri;Lio/github/optimumcode/json/pointer/JsonPointer;)V
Expand Down
2 changes: 2 additions & 0 deletions json-schema-validator/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,4 +342,6 @@ afterEvaluate {
tasks.named("check").configure {
dependsOn(detektAllTask)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ktlint] reported by reviewdog 🐶
Unexpected blank line(s) before "}" (standard:no-blank-line-before-rbrace)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ktlint] reported by reviewdog 🐶
Needless blank line(s) (standard:no-consecutive-blank-lines)

}
9 changes: 9 additions & 0 deletions ...-schema-validator/src/commonMain/kotlin/io/github/optimumcode/json/pointer/JsonPointer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,15 @@ public sealed class JsonPointer(
*/
public fun atIndex(index: Int): JsonPointer {
require(index >= 0) { "negative index: $index" }
if (true) {
if (true) {
if (true) {
if (true) {
val a = 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[detekt] reported by reviewdog 🐶
This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[detekt] reported by reviewdog 🐶
Private property a is unused. [UnusedPrivateProperty]

}
}
}
}
return insertLast(
SegmentPointer(
propertyName = index.toString(),
Expand Down
2 changes: 1 addition & 1 deletion ...validator/src/commonMain/kotlin/io/github/optimumcode/json/pointer/internal/extensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import io.github.optimumcode.json.pointer.EmptyPointer
import io.github.optimumcode.json.pointer.JsonPointer
import io.github.optimumcode.json.pointer.SegmentPointer

internal val JsonPointer.length: Int
public val JsonPointer.length: Int
get() {
if (this is EmptyPointer) {
return 0
Expand Down
Loading