Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Uri class from kmp-uri library in JsonSchemaLoader's public API #133

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

OptimumCode
Copy link
Owner

Resolves #132

@OptimumCode OptimumCode added the enhancement New feature or request label Jun 12, 2024
@OptimumCode OptimumCode changed the title Issue #132 Use Uri class from kmp-uri library in JsonSchemaLoader's public API Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.76%. Comparing base (e9acf35) to head (623d80d).
Report is 1 commits behind head on main.

Files Patch % Lines
...b/optimumcode/json/schema/internal/SchemaLoader.kt 94.33% 1 Missing and 2 partials ⚠️
...github/optimumcode/json/schema/JsonSchemaLoader.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files         124      124           
  Lines        3637     3671   +34     
  Branches     1023     1023           
=======================================
+ Hits         3301     3332   +31     
- Misses         56       59    +3     
  Partials      280      280           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode enabled auto-merge (squash) June 12, 2024 14:53
@OptimumCode OptimumCode merged commit fcf9f70 into main Jun 12, 2024
9 of 10 checks passed
@OptimumCode OptimumCode deleted the issue_#132 branch June 13, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: add Uri to API for JsonSchemaLoader
1 participant