Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all the css into tailwind css on FlatCard component #1788

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

subhajit20
Copy link
Contributor

Description of changes

Replaced all the css into tailwind css on FlatCard component
Issue - #1725

Before:
Before

After:
After

Issue Resolved

Fixes #NA

Screenshots/GIFs

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 6:20pm
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 6:20pm

Copy link

cypress bot commented Jan 5, 2024

1 flaky test on run #4594 ↗︎

0 35 0 0 Flakiness 1

Details:

Replaced all the css into tailwind css on FlatCard component
Project: operation_code Commit: 9878dffac0
Status: Passed Duration: 03:21 💡
Started: Jan 16, 2024 6:22 PM Ended: Jan 16, 2024 6:25 PM
Flakiness  cypress/e2e/modal.spec.js • 1 flaky test • all tests

View Output Video

Test Artifacts
when the server responds successfully > closes the modal when the x button is clicked Screenshots Video

Review all test suite changes for PR #1788 ↗︎

Copy link
Member

@kylemh kylemh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's easier for me to review if you delete the CSS file so I can compare in the diff view!

@subhajit20
Copy link
Contributor Author

it's easier for me to review if you delete the CSS file so I can compare in the diff view!

hey If I delete the CSS file then one class will be corrupted {styles.children} then what to do ?

@kylemh
Copy link
Member

kylemh commented Jan 14, 2024

There doesn't appear to be any .children class in FlatCard.module.css, so I think you're safe to delete that reference so:

<div className={styles.children}> can become <div>

@subhajit20
Copy link
Contributor Author

There doesn't appear to be any .children class in FlatCard.module.css, so I think you're safe to delete that reference so:

<div className={styles.children}> can become <div>

Yes I have deleted the css file.

components/Cards/FlatCard/FlatCard.js Outdated Show resolved Hide resolved
components/Cards/FlatCard/FlatCard.js Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Jan 16, 2024

Code Climate has analyzed commit 9878dff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 75.6% (0.0% change).

View more on Code Climate.

@kylemh kylemh merged commit 05675cb into OperationCode:main Jan 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants