Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all the css into tailwind css on TimelineNav component #1787

Merged
merged 7 commits into from
Jan 5, 2024

Conversation

subhajit20
Copy link
Contributor

Description of changes

Replaced all the css into tailwind css on TimelineNav component
Issue - #1725

Issue Resolved

Fixes #NA

Screenshots/GIFs

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 10:19am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 10:19am

Copy link

cypress bot commented Dec 20, 2023

1 flaky test on run #4589 ↗︎

0 35 0 0 Flakiness 1

Details:

Replaced all the css into tailwind css on TimelineNav component
Project: operation_code Commit: 9bd2ecd13c
Status: Passed Duration: 02:59 💡
Started: Dec 21, 2023 10:21 AM Ended: Dec 21, 2023 10:24 AM
Flakiness  cypress/e2e/modal.spec.js • 1 flaky test • all tests

View Output Video

Test Artifacts
when the server responds successfully > closes the modal when the x button is clicked Screenshots Video

Review all test suite changes for PR #1787 ↗︎

components/Timeline/TimelineNav/TimelineNav.js Outdated Show resolved Hide resolved
components/Timeline/TimelineNav/TimelineNav.js Outdated Show resolved Hide resolved
components/Timeline/TimelineNav/TimelineNav.js Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Dec 21, 2023

Code Climate has analyzed commit 9bd2ecd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 75.6% (0.0% change).

View more on Code Climate.

@subhajit20
Copy link
Contributor Author

Hi @kylemh ,
Is there any changes needed?

@subhajit20
Copy link
Contributor Author

Btw Happy New Year 🙏🏻

Copy link
Member

@kylemh kylemh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy new year!

@kylemh kylemh merged commit 4bce3a1 into OperationCode:main Jan 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants