Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all the css into tailwind css on OutboundLink component #1773

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

subhajit20
Copy link
Contributor

Description of changes

Replaced all the css into tailwind css on OutboundLink component
Issue - #1725

Before:
Before

After:
After

Issue Resolved

Fixes #NA

Screenshots/GIFs

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 4:36pm
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 4:36pm

Copy link

cypress bot commented Nov 17, 2023

1 flaky test on run #4543 ↗︎

0 35 0 0 Flakiness 1

Details:

Replaced all the css into tailwind css on OutboundLink component
Project: operation_code Commit: 84e2c28290
Status: Passed Duration: 02:50 💡
Started: Nov 20, 2023 4:37 PM Ended: Nov 20, 2023 4:40 PM
Flakiness  cypress/e2e/modal.spec.js • 1 flaky test • all tests

View Output Video

Test Artifacts
when the server responds successfully > closes the modal when the x button is clicked Screenshots Video

Review all test suite changes for PR #1773 ↗︎

@subhajit20
Copy link
Contributor Author

hey @kylemh , is there any changes needed?

@kylemh
Copy link
Member

kylemh commented Nov 20, 2023

Unit tests are failing!

@subhajit20
Copy link
Contributor Author

Unit tests are failing!

done

Copy link

codeclimate bot commented Nov 20, 2023

Code Climate has analyzed commit 84e2c28 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 75.6% (0.0% change).

View more on Code Climate.

@kylemh kylemh merged commit b00ba2e into OperationCode:main Nov 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants