Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all the css into tailwind css on ProgressIndicator component #1765

Merged
merged 6 commits into from
Nov 12, 2023

Conversation

subhajit20
Copy link
Contributor

Description of changes

Replaced all the css into tailwind css on ProgressIndicator component
Issue - #1725

Before:
Before

After:
After

Issue Resolved

Fixes #NA

Screenshots/GIFs

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ❌ Failed (Inspect) Nov 10, 2023 10:55am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 10:55am

Copy link

cypress bot commented Nov 9, 2023

1 flaky test on run #4522 ↗︎

0 35 0 0 Flakiness 1

Details:

Merge branch 'main' into 1725/ProgressIndicator
Project: operation_code Commit: 0f5d781bfa
Status: Passed Duration: 03:10 💡
Started: Nov 10, 2023 10:55 AM Ended: Nov 10, 2023 10:59 AM
Flakiness  cypress/e2e/modal.spec.js • 1 flaky test • all tests

View
Output
Video

Test Artifacts
when the server responds successfully > closes the modal when the x button is clicked Screenshots Video

Review all test suite changes for PR #1765 ↗︎

@kylemh
Copy link
Member

kylemh commented Nov 9, 2023

Because of the broken tests, I just realized in #1766 that we haven't been updating snapshot tests.

I'm glad you started trying the UI in Storybook alongside your changes to verify them! In addition, please remember to run yarn test -u

We do run tests as part of a pre-commit hook, but perhaps you've been skipping those? Unsure though... You have been running them, maybe it's because the automatic tailwind class sorting? Unsure.

@subhajit20
Copy link
Contributor Author

Because of the broken tests, I just realized in #1766 that we haven't been updating snapshot tests.

I'm glad you started trying the UI in Storybook alongside your changes to verify them! In addition, please remember to run yarn test -u

We do run tests as part of a pre-commit hook, but perhaps you've been skipping those? Unsure though... You have been running them, maybe it's because the automatic tailwind class sorting? Unsure.

After making changes I always run yarn jest components/demoComponent/ -u that modifies all the snapshots required.
but did not know about this yarn test staff.
I will do that. thanks

@kylemh
Copy link
Member

kylemh commented Nov 9, 2023

Instead, simply run yarn test -u and it will see if any snapshot requires an update.

@subhajit20
Copy link
Contributor Author

Instead, simply run yarn test -u and it will see if any snapshot requires an update.

done

Copy link

codeclimate bot commented Nov 10, 2023

Code Climate has analyzed commit 867fc1f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 75.6% (0.0% change).

View more on Code Climate.

@subhajit20
Copy link
Contributor Author

hey @kylemh would you merge this pr now?

@kylemh kylemh merged commit 2b5ad41 into OperationCode:main Nov 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants