-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced all the css into tailwind css on ProgressIndicator component #1765
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 flaky test on run #4522 ↗︎
Details:
cypress/e2e/modal.spec.js • 1 flaky test • all tests
Review all test suite changes for PR #1765 ↗︎ |
Because of the broken tests, I just realized in #1766 that we haven't been updating snapshot tests. I'm glad you started trying the UI in Storybook alongside your changes to verify them! In addition, please remember to run We do run tests as part of a pre-commit hook, but perhaps you've been skipping those? Unsure though... You have been running them, maybe it's because the automatic tailwind class sorting? Unsure. |
After making changes I always run yarn jest components/demoComponent/ -u that modifies all the snapshots required. |
Instead, simply run |
done |
Code Climate has analyzed commit 867fc1f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 75.6% (0.0% change). View more on Code Climate. |
hey @kylemh would you merge this pr now? |
Description of changes
Replaced all the css into tailwind css on ProgressIndicator component
Issue - #1725
Before:
After:
Issue Resolved
Fixes #NA
Screenshots/GIFs