Fix #1858 - crash when adding a modifier to a jewel #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same issue as was fixed in abyss jewels in 9d42348. If there are no options in the crafting table, the "crafting table" option needs to be hidden, or there will be an error when trying to create the tooltip. For good measure, this patch also prevents the crash by checking that there's something in listMod before dereferencing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same issue as was fixed in abyss jewels in 9d42348. If there
are no options in the crafting table, the "crafting table" option needs
to be hidden, or there will be an error when trying to create the
tooltip.
For good measure, this patch also prevents the crash by checking that
there's something in listMod before dereferencing it.