Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for brand attachment range #1819

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add support for brand attachment range #1819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3953f7e
Add parsing capability for brand attachment range
ppoelzl Dec 20, 2019
2d5cb0c
Add calcs tab view for Brand Attachment Range
ppoelzl Dec 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Modules/CalcOffence-3_0.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,9 @@ function calcs.offence(env, actor, activeSkill)
breakdown.AreaOfEffectMod = breakdown.mod(skillCfg, "AreaOfEffect")
end
end
if activeSkill.skillTypes[SkillType.Brand] then
output.BrandAttachmentRange = calcLib.mod(skillModList, skillCfg, "BrandAttachmentRange")
end
if skillFlags.trap then
local baseSpeed = 1 / skillModList:Sum("BASE", skillCfg, "TrapThrowingTime")
output.TrapThrowingSpeed = baseSpeed * calcLib.mod(skillModList, skillCfg, "TrapThrowingSpeed") * output.ActionSpeedMod
Expand Down
4 changes: 4 additions & 0 deletions Modules/CalcSections-3_0.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,10 @@ return {
{ label = "Secondary Radius", haveOutput = "AreaOfEffectRadiusSecondary", { format = "{0:output:AreaOfEffectRadiusSecondary}", { breakdown = "AreaOfEffectRadiusSecondary" }, }, },
{ label = "Tertiary Radius", haveOutput = "AreaOfEffectRadiusTertiary", { format = "{0:output:AreaOfEffectRadiusTertiary}", { breakdown = "AreaOfEffectRadiusTertiary" }, }, },
{ label = "Weapon Range", haveOutput = "WeaponRange", { format = "{0:output:WeaponRange}", { breakdown = "WeaponRange" }, }, },
{ label = "Attachment Range", haveOutput = "BrandAttachmentRange", { format = "x {2:output:BrandAttachmentRange}",
{ breakdown = "BrandAttachmentRange" },
{ modName = "BrandAttachmentRange", cfg = "skill"},
}, },
{ label = "Trap Throw Time", flag = "trap", { format = "{2:output:TrapThrowingTime}s",
{ breakdown = "TrapThrowingTime" },
{ modName = "TrapThrowingSpeed", cfg = "skill" },
Expand Down
1 change: 1 addition & 0 deletions Modules/ModParser-3_0.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ local modNameList = {
["to deal double damage"] = "DoubleDamageChance",
["activation frequency"] = "BrandActivationFrequency",
["brand activation frequency"] = "BrandActivationFrequency",
["brand attachment range"] = "BrandAttachmentRange",
-- Buffs
["onslaught effect"] = "OnslaughtEffect",
["fortify duration"] = "FortifyDuration",
Expand Down