-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge v0.1.0 release #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods `pause` and `unpause` are not exposed by default now. Resolves #314
Add additional check to `approve` + emit_event flag like in solidity. Rely on that `approve` inside `_spend_allowance`. Resolves #313
- [x] Set `motsu` version to `v0.1.0` - [x] Improve version management for the workspace - `contracts`, `lib/crypto`, `examples`, and `benches` use version set for the whole workspace - `motsu`, `motsu-proc`, `e2e`, `e2e-proc` have their own version per crate - [x] Cleanup dependencies for the workspace - [x] Add CI checks for pre-publishing on crates.io - [x] Fix issues with publishing `motsu` to crates.io: ``` cargo publish -p motsu --target wasm32-unknown-unknown --dry-run Updating crates.io index error: all dependencies must have a version specified when publishing. dependency `motsu-proc` does not specify a version Note: The published dependency will use the version from crates.io, the `path` specification will be removed from the dependency declaration. ``` --------- (cherry picked from commit b1eef80)
Adds erc165 standard altogether with a proc macro, that lets to compute interface id in a simple way. <!-- Fill in with issue number --> Resolves #33 #### PR Checklist - [x] Tests - [x] Documentation --------- Co-authored-by: Daniel Bigos <[email protected]> (cherry picked from commit 9b04143)
Resolves #315 I'm leaving comments on things that might need some discussion
Resolves #328 Co-authored-by: Alisander Qoshqosh <[email protected]>
Extends checkpoints implementation without code duplications, albeit it has a bit complex generics
Resolves #312 --------- Co-authored-by: Alisander Qoshqosh <[email protected]>
Co-authored-by: Alisander Qoshqosh <[email protected]>
1 task
✅ Deploy Preview for contracts-stylus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ggonzalez94
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #369