Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge v0.1.0 release #370

Merged
merged 17 commits into from
Oct 18, 2024
Merged

chore: merge v0.1.0 release #370

merged 17 commits into from
Oct 18, 2024

Conversation

bidzyyys
Copy link
Collaborator

Resolves #369

ggonzalez94 and others added 16 commits October 9, 2024 11:08
@ggonzalez94
fix(N-04) Avoid unnecessary swap operation (#321)
7c84e68 
Resolves #317
@qalisander
fix(L-04): Public Exposure of pause and unpause Functions (#311)
af826da 
Methods `pause` and `unpause` are not exposed by default now.

Resolves #314
@ggonzalez94
fix(N-05) improve comments for modifiers (#322)
c056473 
Resolves #318 

I used the term `helpers`, but open to better wording if someone has
suggestions. This touches the same file as #311, so we might need to
update it after we merge that one.
@qalisander
fix(L-03): Missing Checks in ERC-20 Implementation (#310)
59dafb4 
Add additional check to `approve` + emit_event flag like in solidity.
Rely on that `approve` inside `_spend_allowance`.

Resolves #313
@bidzyyys @ggonzalez94
ref: new workspace structure and version management (#280)
a028cf3 
- [x]  Set `motsu` version to `v0.1.0`
- [x] Improve version management for the workspace
- `contracts`, `lib/crypto`, `examples`, and `benches` use version set
for the whole workspace
- `motsu`, `motsu-proc`, `e2e`, `e2e-proc` have their own version per
crate
- [x] Cleanup dependencies for the workspace
- [x] Add CI checks for pre-publishing on crates.io
- [x] Fix issues with publishing `motsu` to crates.io:
```
cargo publish -p motsu --target wasm32-unknown-unknown --dry-run
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `motsu-proc` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.
```

---------

(cherry picked from commit b1eef80)
@qalisander @ggonzalez94
feat: erc165 support interface (#281)
4106d03 
Adds erc165 standard altogether with a proc macro, that lets to compute
interface id in a simple way.

<!-- Fill in with issue number -->
Resolves #33

#### PR Checklist

- [x] Tests
- [x] Documentation

---------

Co-authored-by: Daniel Bigos <[email protected]>
(cherry picked from commit 9b04143)
@ggonzalez94
fix(N-01) Remove TODOs and FixMes (#330)
997fcc0 
Resolves #315 

I'm leaving comments on things that might need some discussion
@bidzyyys @qalisander
fix(L-05): remove redundant error from ECDSA smart contract (#329)
6eeb15c 
Resolves #328

Co-authored-by: Alisander Qoshqosh <[email protected]>
@qalisander
fix(L-01): Incomplete Implementation for checkpoints.rs (#323)
3b560b3 
Extends checkpoints implementation without code duplications, albeit it
has a bit complex generics
@bidzyyys
fix: cannot publish packages to crates.io (#334)
7e770ee 
Resolves #291
@bidzyyys
ref: remove compilation warnings (#344)
b5b5c6b
@bidzyyys @qalisander
fix(L-02): Inconsistent Implementations in ERC-721 Extension #331 (#333)
47d2d9c 
Resolves #312

---------

Co-authored-by: Alisander Qoshqosh <[email protected]>
@bidzyyys
build: v0.1.0 (#341)
14f1911
@bidzyyys
docs: audit report v0.1.0 (#347)
1703d1e
@bidzyyys @qalisander
docs: update README for v0.1.0 (#365)
68745a7 
Co-authored-by: Alisander Qoshqosh <[email protected]>
@bidzyyys
docs: update Antora docs for v0.1.0 (#367)
ca1f26a 
Resolves #366
@bidzyyys bidzyyys self-assigned this Oct 18, 2024
@bidzyyys bidzyyys linked an issue Oct 18, 2024 that may be closed by this pull request
Merge v0.1.0 release branch into main branch #369
Closed
1 task
@netlify Netlify
Copy link

netlify bot commented Oct 18, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus ready!

Name Link
🔨 Latest commit b7c64f2
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67129dd4a7c7b100086b8b41
😎 Deploy Preview https://deploy-preview-370--contracts-stylus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 36 lines in your changes missing coverage. Please review.

Project coverage is 81.9%. Comparing base (46eabf0) to head (b7c64f2).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
contracts/src/token/erc721/extensions/metadata.rs 16.6% 15 Missing ⚠️
...ntracts/src/token/erc721/extensions/uri_storage.rs 83.8% 11 Missing ⚠️
contracts/src/token/erc20/mod.rs 65.2% 8 Missing ⚠️
contracts/src/token/erc20/extensions/permit.rs 0.0% 1 Missing ⚠️
...ntracts/src/token/erc721/extensions/consecutive.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc20/extensions/burnable.rs 100.0% <100.0%> (ø)
contracts/src/token/erc20/extensions/metadata.rs 4.1% <ø> (+0.4%) ⬆️
...ontracts/src/token/erc721/extensions/enumerable.rs 86.7% <ø> (ø)
contracts/src/token/erc721/mod.rs 88.2% <ø> (-0.1%) ⬇️
contracts/src/utils/cryptography/ecdsa.rs 32.9% <ø> (+2.2%) ⬆️
contracts/src/utils/pausable.rs 74.1% <ø> (ø)
...acts/src/utils/structs/checkpoints/generic_size.rs 100.0% <100.0%> (ø)
contracts/src/utils/structs/checkpoints/mod.rs 96.5% <100.0%> (ø)
lib/crypto/src/hash.rs 75.9% <100.0%> (-0.5%) ⬇️
lib/crypto/src/merkle.rs 97.9% <100.0%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

@bidzyyys bidzyyys marked this pull request as ready for review October 18, 2024 17:47
ggonzalez94
ggonzalez94 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ggonzalez94 ggonzalez94 merged commit 6ac429d into main Oct 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggonzalez94 ggonzalez94 ggonzalez94 approved these changes

@qalisander qalisander Awaiting requested review from qalisander qalisander is a code owner

Assignees

@bidzyyys bidzyyys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge v0.1.0 release branch into main branch
3 participants
@bidzyyys @ggonzalez94 @qalisander