fix(L-02): Inconsistent Implementations in ERC-721 Extension #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Set `motsu` version to `v0.1.0`
- [x] Improve version management for the workspace
- `contracts`, `lib/crypto`, `examples`, and `benches` use version set
for the whole workspace
- `motsu`, `motsu-proc`, `e2e`, `e2e-proc` have their own version per
crate
- [x] Cleanup dependencies for the workspace
- [x] Add CI checks for pre-publishing on crates.io
- [x] Fix issues with publishing `motsu` to crates.io:
```
cargo publish -p motsu --target wasm32-unknown-unknown --dry-run
Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `motsu-proc` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.
```
---------
(cherry picked from commit b1eef80)
Adds erc165 standard altogether with a proc macro, that lets to compute interface id in a simple way. <!-- Fill in with issue number --> Resolves #33 #### PR Checklist - [x] Tests - [x] Documentation --------- Co-authored-by: Daniel Bigos <[email protected]> (cherry picked from commit 9b04143)
Adds erc165 standard altogether with a proc macro, that lets to compute interface id in a simple way. <!-- Fill in with issue number --> Resolves #33 #### PR Checklist - [x] Tests - [x] Documentation --------- Co-authored-by: Daniel Bigos <[email protected]> (cherry picked from commit 9b04143)
qalisander
force-pushed
the
fix/L-02-Inconsistent-Implementations-in-ERC-721-Extension
branch
from
cf83cf6
to
e6851f4
Compare
qalisander
commented
Oct 10, 2024
| @@ -2,6 +2,10 @@ | |||
| pragma solidity ^0.8.21; | |||
|
|
|||
| contract Erc721ConsecutiveExample { | |||
| string private _name; | |||
There was a problem hiding this comment.
Changes to solidity constructor bring an error from koba. Without them and without additional fields inside Erc721, consecutive extension's tests can pass.
bidzyyys
added a commit
that referenced
this pull request
Oct 17, 2024
Resolves #312 --------- Co-authored-by: Alisander Qoshqosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are based on ERC-165 (#309). Should be merged after that pr.
Resolves #312