➕ Add connect MetaMask modal #752
Conversation
GianfrancoBazzani
commented
Aug 28, 2024
GianfrancoBazzani
commented
- closes: Consider avoiding auto-connect to Metamask #751
|
Would it make sense to add a way to close the modal, in case the user is not interested in connecting at the moment and just wants to look around? |
yes, absolutely! we have a similar behavior with networks being deprecated |
| </a> | ||
| </div> | ||
| ); | ||
| {this.props.web3 && !store.getState().gamedata.readOnly && ( |
There was a problem hiding this comment.
Once in read-only mode, it's not obvious how to exit read-only mode, especially if the network list is hidden. This could be addressed by doing one or more of the following if in read-only (but I don't think these are a must for this first iteration):
- Adding a button here that brings back the MetaMask modal (or even just directly connects)
- If the user clicks the "Play now!" button on the main page, this is an indication that the user actually wants to connect. In this case, exit read-only mode (or bring back the MetaMask modal, or directly connect)
There was a problem hiding this comment.
I like both options! thanks for the suggestion!
There was a problem hiding this comment.
added a new button here that is displayed only if the game is in readonly mode and allows to connect the account without passing through the modal.
Added also modal trigger when user clicks "Play now!". Let me know if there's any issue.
There was a problem hiding this comment.
This works great now, thanks a lot for addressing these so quickly!
|
The read-only mode was already existing whenever there was no web3 provider injected (different from having it but not being connected to). In the former case, a warning is displayed to remember to the user that the game is on read-only mode. Can we keep the behaviour consistent with that ? To see what I'm talking about you can for example joing the deploy preview from a mobile phone. |
