Add actionlint (#1067)

* add actionlint for workflows

* remove codecov and gitmodules

* bump checkout to v4, add double quotes, fmt

* bump md lint

* re-add cairo version

* group redirects

* fix link in security

* add local actionlint matcher json

.github/actionlint-matcher.json

@@ -0,0 +1,17 @@
+{
+ "problemMatcher": [
+ {
+ "owner": "actionlint",
+ "pattern": [
+ {
+ "regexp": "^(?:\\x1b\\[\\d+m)?(.+?)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*: (?:\\x1b\\[\\d+m)*(.+?)(?:\\x1b\\[\\d+m)* \\[(.+?)\\]$",
+ "file": 1,
+ "line": 2,
+ "column": 3,
+ "message": 4,
+ "code": 5
+ }
+ ]
+ }
+ ]
+ }

.github/workflows/actionlint.yml

@@ -0,0 +1,15 @@
+name: Lint workflows
+
+on:
+ pull_request:
+ paths:
+ - '.github/**/*.ya?ml'
+
+jobs:
+ lint:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - name: Add problem matchers
+ run: echo "::add-matcher::.github/actionlint-matcher.json"
+ - uses: docker://rhysd/actionlint:latest

.github/workflows/prepare-release.yml

@@ -10,25 +10,27 @@ jobs:
 
  steps:
  - name: Checkout repository
- uses: actions/checkout@v3
+ uses: actions/checkout@v4
 
  - name: Extract current versions
  run: |
  CURRENT_VERSION=$(grep '^version = ' Scarb.toml | sed 's/version = "\(.*\)"/\1/')
  SCARB_VERSION=$(grep 'scarb-version = ' Scarb.toml | sed 's/scarb-version = "\(.*\)"/\1/')
  CAIRO_VERSION=$(grep 'cairo-version = ' Scarb.toml | sed 's/cairo-version = "\(.*\)"/\1/')
- echo "CURRENT_VERSION=$CURRENT_VERSION" >> $GITHUB_ENV
- echo "SCARB_VERSION=$SCARB_VERSION" >> $GITHUB_ENV
- echo "CAIRO_VERSION=$CAIRO_VERSION" >> $GITHUB_ENV
+ {
+ echo "CURRENT_VERSION=$CURRENT_VERSION"
+ echo "SCARB_VERSION=$SCARB_VERSION"
+ echo "CAIRO_VERSION=$CAIRO_VERSION"
+ } >> "$GITHUB_ENV"
 
  - name: Extract new version number
- run: echo "NEW_VERSION=${GITHUB_REF#refs/heads/release-v}" >> $GITHUB_ENV
+ run: echo "NEW_VERSION=${GITHUB_REF#refs/heads/release-v}" >> "$GITHUB_ENV"
 
  - name: Replace version in files
  run: |
  echo "Current version: $CURRENT_VERSION"
  echo "New version: $NEW_VERSION"
- ESCAPED_CURRENT_VERSION=$(echo $CURRENT_VERSION | sed 's/\./\\./g')
+ ESCAPED_CURRENT_VERSION="${CURRENT_VERSION//\./\\.}"
  find . -type f -not -path '*/\.*' -not -path './CHANGELOG.md' -not -path './docs/package-lock.json' \
  -not -path './RELEASING.md' -exec sed -i "s/$ESCAPED_CURRENT_VERSION/$NEW_VERSION/g" {} +
 
@@ -45,7 +47,7 @@ jobs:
 
  - name: Update presets page
  run: |
- class_hash get --json | sed -e '1,4d' | python3 scripts/get_hashes_page.py $CAIRO_VERSION \
+ class_hash get --json | sed -e '1,4d' | python3 scripts/get_hashes_page.py "$CAIRO_VERSION" \
  > ./docs/modules/ROOT/pages/utils/_class_hashes.adoc
 
  - name: Auto-commit changes

.github/workflows/test.yml

@@ -13,16 +13,16 @@ jobs:
  name: Lint and test
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
  - name: Extract scarb version
  run: |
  SCARB_VERSION=$(grep 'scarb-version = ' Scarb.toml | sed 's/scarb-version = "\(.*\)"/\1/')
- echo "SCARB_VERSION=$SCARB_VERSION" >> $GITHUB_ENV
+ echo "SCARB_VERSION=$SCARB_VERSION" >> "$GITHUB_ENV"
  - uses: software-mansion/setup-scarb@v1
  with:
  scarb-version: ${{ env.SCARB_VERSION }}
  - name: Markdown lint
- uses: DavidAnson/markdownlint-cli2-action@5b7c9f74fec47e6b15667b2cc23c63dff11e449e # v9
+ uses: DavidAnson/markdownlint-cli2-action@b4c9feab76d8025d1e83c653fa3990936df0e6c8 # v16
  with:
  globs: |
  *.md

SECURITY.md

@@ -3,4 +3,4 @@
 > ⚠️ Warning! ⚠️
 > This project is still in a very early and experimental phase. It has never been audited nor thoroughly reviewed for security vulnerabilities. Do not use in production.
 
-Please report any security issues you find to [email protected].
+Please report any security issues you find to <[email protected]>.