Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timing(DCache): delay tag error to s3 instead of s2 #3908

Merged
merged 1 commit into from
Nov 22, 2024
Merged

timing(DCache): delay tag error to s3 instead of s2 #3908

merged 1 commit into from
Nov 22, 2024

Conversation

cz4e
Copy link
Contributor

@cz4e cz4e commented Nov 21, 2024

  • break hitVec -> ldu tag_error -> loadunit path

@cz4e cz4e added the timing Fix bad timing label Nov 21, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 988eb89

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
988eb89 1.917 0.450 2.701 1.235 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
6639e9a
399766d 1.917 0.450 2.701 1.234 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
6266af8
dd980d6
b6cec43 1.917 0.450 2.701 1.227 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

@linjuanZ linjuanZ changed the title timing(DCache): use error_delayed at s3 instead of ldu.resp.tag_error at s2 timing(DCache): delay tag error to s3 instead of s2 Nov 22, 2024
@linjuanZ linjuanZ merged commit 92bcee1 into master Nov 22, 2024
9 checks passed
@linjuanZ linjuanZ deleted the timing-dcache-tag-error branch November 22, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linjuanZ linjuanZ linjuanZ approved these changes

@good-circle good-circle Awaiting requested review from good-circle good-circle is a code owner

@happy-lx happy-lx Awaiting requested review from happy-lx happy-lx is a code owner

@bosscharlie bosscharlie Awaiting requested review from bosscharlie bosscharlie is a code owner

Assignees
No one assigned
Labels
timing Fix bad timing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cz4e @XiangShanRobot @linjuanZ