Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): add ClockGate at frontend SRAMTemplate #3889

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat(frontend): add ClockGate at frontend SRAMTemplate #3889

merged 2 commits into from
Nov 19, 2024

Conversation

Lawrence-ID
Copy link
Collaborator

  • Add param withClockGate at SRAMTemplate
  • when SRAM is single-port, use maskedClock for both array.read() and array.write() to ensure single-port SRAM access.
  • when SRAM is multi-port, the read and write ports of the multi-port SRAM are gated using different clocks.

@Lawrence-ID
feat: add ClockGate at SRAMTemplate
4fbba5d 
* Add param `withClockGate` at SRAMTemplate
* when SRAM is single-port, use maskedClock for both array\.read\(\) and array\.write\(\) to ensure single-port SRAM access.
* when SRAM is multi-port, the read and write ports of the multi-port SRAM are gated using different clocks.
@Lawrence-ID Lawrence-ID changed the title feat: add ClockGate at frontend SRAMTemplate feat(frontend): add ClockGate at frontend SRAMTemplate Nov 18, 2024
@Lawrence-ID Lawrence-ID added the power about power design or optimization label Nov 18, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: e335769

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
e335769 1.917 0.450 2.697 1.229 2.840 2.464 2.398 0.920 1.430 2.069 3.432 2.720 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
3e2285d 1.917 0.450 2.701 1.226 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
c49ebec 1.917 0.450 2.696 1.230 2.840 2.464 2.398 0.920 1.430 2.069 3.432 2.720 2.387 3.261
cfa1639 0.450 2.701 1.244 2.473 2.398 0.915 1.429 1.700 3.470 2.729 3.280
0d13456 1.920 0.450 2.701 1.234 2.891 2.473 2.398 0.915 1.429 1.700 3.470 2.729 2.417 3.280
011f1ef 1.917 0.450 2.701 1.241 2.891 2.473 2.398 0.915 1.429 1.700 3.470 2.729 2.417 3.280

eastonman
eastonman approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gao-Zeyu Gao-Zeyu merged commit 39d5540 into master Nov 19, 2024
9 checks passed
@Gao-Zeyu Gao-Zeyu deleted the frontend-SRAMClockGated branch November 19, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gao-Zeyu Gao-Zeyu Gao-Zeyu approved these changes

@ngc7331 ngc7331 ngc7331 approved these changes

@eastonman eastonman eastonman approved these changes

Assignees
No one assigned
Labels
power about power design or optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lawrence-ID @XiangShanRobot @eastonman @ngc7331 @Gao-Zeyu