Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix play media for timer #9

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix play media for timer #9

merged 1 commit into from
Jan 10, 2024

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Jan 10, 2024 •
edited
Loading

turns off volume escalation for timers (that lead to an exception)

closes: #8

@emphasize emphasize self-assigned this Jan 10, 2024
@emphasize emphasize added the bug Something isn't working label Jan 10, 2024
@emphasize emphasize merged commit 5c6c92f into dev Jan 10, 2024
8 of 9 checks passed
mikejgray
mikejgray reviewed Jan 10, 2024
View reviewed changes
Copy link

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to put a ceiling on the volume, so it doesn't exceed 100%, or does that happen elsewhere?

@JarbasAl JarbasAl deleted the fix/escalate_volume branch October 15, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikejgray mikejgray mikejgray left review comments

Assignees

@emphasize emphasize

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when trying to play sound when timer finish
2 participants
@emphasize @mikejgray