Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ansible/venv] Install ggawave skill from PyPi #188

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

goldyfruit
Copy link
Member

@goldyfruit goldyfruit commented Oct 17, 2024

Summary by CodeRabbit

  • New Features

    • Conditional inclusion of the ovos-core[skills-audio] dependency based on the installation profile.
    • Updated dependency specification for ovos-skill-ggwave to simplify installation under certain conditions.
  • Bug Fixes

    • Improved dependency handling for different architectures and profiles to enhance installation reliability.

@goldyfruit goldyfruit added the enhancement New feature or request label Oct 17, 2024
@goldyfruit goldyfruit added this to the Wolfenstein milestone Oct 17, 2024
@goldyfruit goldyfruit self-assigned this Oct 17, 2024
Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request modify the skills-requirements.txt.j2 template within the ovos_installer role. A conditional inclusion of the ovos-core[skills-audio] dependency is introduced based on the ovos_installer_profile value. If the profile is not "server", this dependency is included. Additionally, the ovos-skill-ggwave dependency is updated from a Git repository URL to a package name under specific conditions related to architecture and profile settings.

Changes

File Change Summary
ansible/roles/ovos_installer/templates/virtualenv/skills-requirements.txt.j2 - Conditional inclusion of ovos-core[skills-audio] based on ovos_installer_profile.
- Updated ovos-skill-ggwave from Git URL to package name under conditions (architecture or profile).

Possibly related PRs

  • use pypi #144: The changes in this PR also involve modifications to the skills-requirements.txt.j2 template, specifically in how dependencies are referenced, which aligns with the updates made in the main PR regarding the ovos-skill-ggwave dependency.

Suggested labels

bug

Suggested reviewers

  • JarbasAl

🐇 In the meadow, changes bloom,
Skills and profiles find their room.
Dependencies dance, both new and old,
In the code, their stories told.
A rabbit's cheer for updates bright,
Hopping forward, all feels right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@goldyfruit goldyfruit merged commit cf831ce into main Oct 17, 2024
7 checks passed
@goldyfruit goldyfruit deleted the fix/handle_phal_admin_with_wrapper branch October 17, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant