[ansible/templates] Use SOX player for wav and mp3 by default

[goldyfruit]

SOX is capable of handling wav and mp3 files which make it easier to manager rather than having a combination of aplay, paplay, pw-play, etc...

Summary by CodeRabbit

• New Features

  • Simplified audio playback commands for WAV and MP3 files.
  • Dynamic configuration for max_msg_size based on GUI feature and installation method.
  • Conditional inclusion of settings for audio, intents, and GUI based on installation profile and architecture.

• Bug Fixes

  • Improved logging path settings for container installations.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on the mycroft.conf.j2 template file within the ovos_installer role. The modifications simplify the command-line playback commands for WAV and MP3 files by removing the conditional logic based on the sound server. Instead, a unified command play %1 is used for both formats. The overall configuration structure remains intact, with various conditional settings based on installation methods, profiles, architectures, and hardware capabilities.

Changes

File	Change Summary
ansible/roles/ovos_installer/templates/mycroft.conf.j2	Simplified playback commands for WAV and MP3 files by using play %1, removing sound server conditionals. Retained overall configuration structure with conditional settings for features based on installation method, profile, architecture, and hardware capabilities.

Possibly related PRs

• [audio/template] Configure OCP when Mark II is detected #117: The changes in this PR also modify the mycroft.conf.j2 template file, adding conditional configurations for audio backends based on the presence of specific devices, which relates to the overall audio configuration changes made in the main PR.

Poem

In the land of code where rabbits play,
A template changed in a bright new way.
With commands so simple, they hop with glee,
No more conditions, just play %1 for me!
Configs aligned, like carrots in rows,
A joyful update, as the project grows! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[JarbasAl]

wasnt the original change done for performance reasons because of lower latency?

[goldyfruit]

wasnt the original change done for performance reasons because of lower latency?

Its was for less than 2 milliseconds but I just encountered an issue with paplay and pw-play which were supposed to play a sound but on play was able to do it.

Choosing reliability over performances.