Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ansible/template] Fix requirements #177

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[ansible/template] Fix requirements #177

merged 1 commit into from
Oct 11, 2024

Conversation

goldyfruit
Copy link
Member

@goldyfruit goldyfruit commented Oct 11, 2024

Remove WiFi PHAL plugin and perform some cleaning.

Summary by CodeRabbit

  • New Features

    • Updated dependency management for the OVOS project, enhancing support for audio and device integration.
    • Conditional inclusion of specific dependencies based on architecture and installation profile.
  • Bug Fixes

    • Removed outdated and unnecessary dependencies to streamline installation.
  • Documentation

    • Clarified conditions for including certain packages based on device presence and architecture.

@goldyfruit goldyfruit added bug Something isn't working enhancement New feature or request labels Oct 11, 2024
@goldyfruit goldyfruit added this to the Descent milestone Oct 11, 2024
@goldyfruit goldyfruit self-assigned this Oct 11, 2024
Copy link
Contributor

coderabbitai bot commented Oct 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to three template files related to dependency management in the OVOS project. The core-requirements.txt.j2 file sees several dependencies removed and added, with specific conditions based on architecture and CPU capabilities. The satellite-requirements.txt.j2 file also undergoes reorganization of its dependencies, while the skills-requirements.txt.j2 file introduces conditional logic for including certain dependencies based on the installer profile. These updates reflect a refinement of the project's dependency structure.

Changes

File Path Change Summary
ansible/roles/ovos_installer/templates/virtualenv/core-requirements.txt.j2 - Removed: ovos-messagebus, ovos-tts-plugin-polly, onnxruntime, vosk (commented out)
- Added: ovos-audio[extras], ovos-PHAL[linux], ovos-phal-plugin-ipgeo
- Conditionally added: ovos-audio-transformer-plugin-ggwave, ovos-PHAL[mk1], ovos-PHAL[mk2], ovos-PHAL[mk2dev]
ansible/roles/ovos_installer/templates/virtualenv/satellite-requirements.txt.j2 - Removed: ovos-dinkum-listener[extras,linux], ovos-PHAL[extras,linux]
- Added: ovos-PHAL[linux], ovos-phal-plugin-ipgeo
- Re-added: ovos-dinkum-listener[extras,linux] (reordered)
ansible/roles/ovos_installer/templates/virtualenv/skills-requirements.txt.j2 - Introduced conditional inclusion for ovos-core[skills-audio] based on ovos_installer_profile
- Updated conditions for including ovos-skill-ggwave based on architecture and profile

Possibly related PRs

Suggested reviewers

  • JarbasAl

🐰 In the meadow, where dependencies grow,
A rabbit hops, with a list in tow.
Some were removed, and new ones came,
Conditional paths, never the same.
With a twitch of my nose, I celebrate this change,
In the world of code, nothing feels strange! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@goldyfruit goldyfruit merged commit 5d45da0 into main Oct 11, 2024
7 checks passed
@goldyfruit goldyfruit deleted the fix/requirements branch October 11, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant