[ansible/video] Detect WAYLAND_DISPLAY and dynamic DISPLAY

[goldyfruit]

Summary by CodeRabbit

• New Features

  • Enhanced compatibility with Wayland display server by introducing conditional tasks to check for Wayland sockets.
  • Added configurability for the WAYLAND_DISPLAY environment variable based on the presence of a new fact.

• Bug Fixes

  • Improved clarity in the management of environment variables for GUI applications in Docker by updating task descriptions.

[coderabbitai]

Walkthrough

This update enhances the Ansible playbook for the OVOS installer by adding support for the Wayland display server. It introduces tasks to check for Wayland sockets and conditionally sets the WAYLAND_DISPLAY environment variable. This improvement boosts compatibility with systems using Wayland and increases configurability for users needing graphical output via Docker.

Changes

Files	Change Summary
ansible/roles/ovos_installer/tasks/video.yml	Added tasks to check for Wayland sockets and set ovos_installer_wayland_display, enhancing playbook functionality for Wayland.
ansible/roles/ovos_installer/templates/docker/env.j2	Introduced conditional setting of WAYLAND_DISPLAY based on ovos_installer_wayland_display, defaulting to 'wayland-0'.
ansible/roles/ovos_installer/tasks/docker/composer.yml	Updated task name to indicate removal of both DISPLAY and WAYLAND_DISPLAY variables if EGLFS is used, clarifying its scope.

Poem

🐇 In the land of code where rabbits play,
New features bloom like flowers in May.
With Wayland's light, our path is clear,
Configurable dreams, we hold dear.
So hop along, let's celebrate,
For every change, we elevate! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d983745 and dcdf44c.

Files selected for processing (2)

• ansible/roles/ovos_installer/tasks/video.yml (1 hunks)
• ansible/roles/ovos_installer/templates/docker/env.j2 (1 hunks)

Additional comments not posted (1)

ansible/roles/ovos_installer/templates/docker/env.j2 (1)

56-56: LGTM!

The changes enhance the configurability of the environment setup by allowing users to specify the Wayland display.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dcdf44c and 980104d.

Files selected for processing (1)

• ansible/roles/ovos_installer/tasks/video.yml (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• ansible/roles/ovos_installer/tasks/video.yml

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 980104d and 635bdb0.

Files selected for processing (1)

• ansible/roles/ovos_installer/tasks/video.yml (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• ansible/roles/ovos_installer/tasks/video.yml

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 635bdb0 and 3aa9e8d.

Files selected for processing (3)

• ansible/roles/ovos_installer/tasks/docker/composer.yml (1 hunks)
• ansible/roles/ovos_installer/tasks/video.yml (1 hunks)
• ansible/roles/ovos_installer/templates/docker/env.j2 (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• ansible/roles/ovos_installer/tasks/video.yml

Additional comments not posted (2)

ansible/roles/ovos_installer/templates/docker/env.j2 (1)

56-58: LGTM! The new environment variable enhances configurability.

The addition of WAYLAND_DISPLAY conditionally set based on ovos_installer_wayland_display is a good enhancement for systems using Wayland.

ansible/roles/ovos_installer/tasks/docker/composer.yml (1)

24-24: Clearer task name.

The updated task name accurately reflects the removal of both DISPLAY and WAYLAND_DISPLAY variables when EGLFS is used, improving clarity.