Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/reranker+optional_ovos_classifiers #529

Merged
merged 8 commits into from
Aug 4, 2024

Commits on Aug 3, 2024

  1. packaging/optional_ovos_classifiers

    ovos-classifiers is still in pre-alpha and wont have a stable release anytime soon, make it an optional dependency of ovos-core 0.0.8
    JarbasAl committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    ca7bd9f View commit details
    Browse the repository at this point in the history
  2. test requirements.txt

    JarbasAl committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    0e915b5 View commit details
    Browse the repository at this point in the history
  3. fix tests

    JarbasAl committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    e85d1ef View commit details
    Browse the repository at this point in the history
  4. tests

    JarbasAl committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    f60e12a View commit details
    Browse the repository at this point in the history
  5. optional ovos-classifiers

    JarbasAl committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    6de6954 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0cf8096 View commit details
    Browse the repository at this point in the history
  7. Update ovos_core/intent_services/commonqa_service.py

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    JarbasAl and coderabbitai[bot] authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    1a0565e View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. add explicit logs about reranking process

    ```
    2024-08-04 01:46:56.692 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:269 - DEBUG - Tied skills: ['skill-ovos-ddg.openvoiceos', 'skill-ovos-wikipedia.openvoiceos', 'skill-ovos-wolfie.openvoiceos']
    2024-08-04 01:46:56.693 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:275 - DEBUG - ReRanking answers from skills
    2024-08-04 01:46:56.974 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:280 - INFO - ReRanked score: 0.9994009733200073 - {'phrase': 'what is the speed of light', 'skill_id': 'skill-ovos-ddg.openvoiceos', 'answer': 'The speed of light in vacuum, commonly denoted c, is a universal physical constant that is exactly equal to 299,792,458 metres per second.', 'handles_speech': True, 'callback_data': {'query': 'what is the speed of light', 'answer': 'The speed of light in vacuum, commonly denoted c, is a universal physical constant that is exactly equal to 299,792,458 metres per second.'}, 'conf': 2.229565217391304}
    2024-08-04 01:46:56.975 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:280 - INFO - ReRanked score: 0.9994009733200073 - {'phrase': 'what is the speed of light', 'skill_id': 'skill-ovos-wikipedia.openvoiceos', 'answer': 'The speed of light in vacuum, commonly denoted c, is a universal physical constant that is exactly equal to 299,792,458 metres per second .', 'handles_speech': True, 'callback_data': {'query': 'what is the speed of light', 'image': 'https://upload.wikimedia.org/wikipedia/commons/2/2e/Earth_to_Sun_-_en.png', 'title': 'Speed Of Light', 'answer': 'The speed of light in vacuum, commonly denoted c, is a universal physical constant that is exactly equal to 299,792,458 metres per second .'}, 'conf': 2.1133333333333333}
    2024-08-04 01:46:56.975 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:280 - INFO - ReRanked score: 0.9967312812805176 - {'phrase': 'what is the speed of light', 'skill_id': 'skill-ovos-wolfie.openvoiceos', 'answer': 'The speed of light has a value of about 300 million meters per second', 'handles_speech': True, 'callback_data': {'query': 'what is the speed of light', 'answer': 'The speed of light has a value of about 300 million meters per second'}, 'conf': 2.8085714285714287}
    2024-08-04 01:46:56.975 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:287 - INFO - Handling with: skill-ovos-ddg.openvoiceos
    ```
    
    add "ignore_skill_scores" config option, rely on the reranker for best answer selection while ignore self reported confidence by skills
    JarbasAl committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    6b268fb View commit details
    Browse the repository at this point in the history