Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdr_split: fix null slot frame addr #685

Merged
merged 1 commit into from
Jan 4, 2024
Merged

hdr_split: fix null slot frame addr #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion doc/experimental/header_split.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,22 @@ Header split is a hardware-based feature for RX memory copy offload. It can leve

## 2. Build DPDK with header split patch

Note: please checkout DPDK to v23.03 as it is verified. It has known raw flow issues with DPDK v23.08 and v23.11.

```bash
git am patches/dpdk/23.07/hdr_split/0001-net-ice-support-hdr-split-mbuf-callback.patch
cd dpdk
# checkout v23.03 version
git checkout v23.03
git switch -c v23.03
git am $imtl_source_code/patches/dpdk/23.03/*.patch
git am $imtl_source_code/patches/dpdk/23.03/hdr_split/0001-net-ice-support-hdr-split-mbuf-callback.patch

# build dpdk
rm build -rf
meson setup build
ninja -C build
sudo ninja install -C build
cd ..
```

## 3. Update DDP package version with header split feature
Expand Down
2 changes: 1 addition & 1 deletion lib/src/st2110/st_rx_video_session.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2341,7 +2341,7 @@ static int rv_handle_hdr_split_pkt(struct st_rx_video_session_impl* s,

/* find the target slot by tmstamp */
bool exist_ts = false;
struct st_rx_video_slot_impl* slot = rv_slot_by_tmstamp(s, tmstamp, NULL, &exist_ts);
struct st_rx_video_slot_impl* slot = rv_slot_by_tmstamp(s, tmstamp, payload, &exist_ts);
if (!slot || !slot->frame) {
if (exist_ts) {
s->stat_pkts_redundant_dropped++;
Expand Down
Loading