-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: gsteamer plugin for sending ancillary data #1044
Conversation
f8d84a5
to
1693bee
Compare
Please add a paragraph why the code in RX plugin was changed as this is also part of this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try ty keep things consinstant generally but all of those are suggestions
This code is fine :<
But i would love it to be more readable
The things i would recommend is to be consistent with the side of literals
I would put them all on the left side in comparisons in new code
Feel free to ignore the comments you deem unnecessary
This can be a part of a larger refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major, but there are a few places that would require modifications. ;)
Signed-off-by: Kasiewicz, Marek <[email protected]>
Signed-off-by: Kasiewicz, Marek <[email protected]>
Signed-off-by: Kasiewicz, Marek <[email protected]>
Add DID, SDID and framerate parameters to st40 tx plugin Fix code formatting Signed-off-by: Kasiewicz, Marek <[email protected]>
1693bee
to
ee0557d
Compare
Signed-off-by: Kasiewicz, Marek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix tests tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
Signed-off-by: Kasiewicz, Marek <[email protected]>
Signed-off-by: Kasiewicz, Marek <[email protected]>
This PR adds:
The plugin requires more logic to be able to sync with Video plugin, as it needs to send ancillary data in sync with video frames. ( with the same timestamp). This is to be done later.