Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Gstreamer plugin for ST30TX #1027

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

Sakoram
Copy link
Collaborator

@Sakoram Sakoram commented Dec 20, 2024

example launch command:

gst-launch-1.0 filesrc location=/home/gta/mkasiew/audio-samp/f1_s16le_48000.pcm blocksize=70000 !
rawaudioparse format=pcm sample-rate=48000 pcm-format=s16le num-channels=1 !
mtlst30tx tx-queues=4 tx-udp-port=20000tx-payload-type=111 dev-ip="192.168.96.3" tx-ip="192.168.96.2" dev-port="0000:4b:11.0"

ecosystem/gstreamer_plugin/gstmtlst30tx.h Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gstmtlst30tx.h Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gstmtlst30tx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gstmtlst30tx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gstmtlst30tx.h Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gstmtlst30tx.h Outdated Show resolved Hide resolved
@DawidWesierski4
Copy link
Collaborator

Another thing in another commit i am making the "central" files could be worthwhile to first go with that commit then just kick all the parsing you do here to common ?

@DawidWesierski4
Copy link
Collaborator

Also please use a good commit message

Just a tad bit of a word about how this works mby?

What does it introduce to the code base ?

the launch command passed to the "To test" or "to launch" with clear description
how to check if this work mby ?

why so skimpy ;-;

@Sakoram Sakoram force-pushed the gsteamer-plugin-st30tx branch from 2039198 to e47ccff Compare January 7, 2025 09:48
Signed-off-by: Kasiewicz, Marek <[email protected]>
@Sakoram Sakoram force-pushed the gsteamer-plugin-st30tx branch 6 times, most recently from e74c300 to 50e03ab Compare January 7, 2025 11:00
@Sakoram Sakoram force-pushed the gsteamer-plugin-st30tx branch from 50e03ab to 46611cc Compare January 7, 2025 12:14
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sakoram Sakoram merged commit 12098ba into OpenVisualCloud:main Jan 7, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants