Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: order documentation in MTL #1024

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

skolelis
Copy link
Collaborator

@skolelis skolelis commented Dec 19, 2024

Docs: order documentation in MTL (and also paralely in BCS and MCM repos (as MTL will be used as sub-module there)).

Style of chapters change,
comas, points, colons, numbering of sections,
style of source code blocks consistent,
source code with commend lines to be paste'able for user,
isolate some parts of the text to be reused also in the documents of others repositories.
Sphinx added generating the documentaries.
Added ST41 to the architecture diagram.
Added X540-AT2/X550T NICs to the architecture diagram.

@DawidWesierski4 DawidWesierski4 changed the title ordering documentation in MTL (and also BCS, MCM (in case MTL is used as sub-module)) Docs: ordering documentation in MTL (and also BCS, MCM (in case MTL is used as sub-module)) Dec 19, 2024
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to 72 character title limit
with
Docs: as title

Also please in the PR include a solid commit message
What are you changing
and why ?

Those 2 questions should be in the PR description before merging

doc/build.md Outdated Show resolved Hide resolved
doc/png/arch.svg Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI for other people ST41 was added

This is why we need good description

Also wasn't there support for another intel NIC added?
dc0d02a dev: add support for ixgbe driver (#932)

i didn't test it myself but shouldn't this be added in the NIC Hardware section ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this drawing now, but it should be added few months ago. I had it ready then, but somehow was ommitted. Then just ST41 was added and I also removed I from IMTL -> MTL.
I dont know about other necessary changes .

doc/run.md Show resolved Hide resolved
@skolelis skolelis changed the title Docs: ordering documentation in MTL (and also BCS, MCM (in case MTL is used as sub-module)) Docs: ordering documentation in MTL Jan 22, 2025
@skolelis skolelis changed the title Docs: ordering documentation in MTL Docs: order documentation in MTL Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants