Fix: flow rules failing after verification on PF #1021
Merged
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawidWesierski4
force-pushed
the
Fix_failed_flow_rules
branch
2 times, most recently
from
83ef9e2 to
d478b90
Compare
DawidWesierski4
changed the title
DPDK backend flow rules are failing on the E810 PF when ETH rules are ignored on the default attribute group 0. Retry applying the flow rules on the queue with group 2 if applying to group 0 fails but passes verification.
DawidWesierski4
force-pushed
the
Fix_failed_flow_rules
branch
from
d478b90 to
ff26ce2
Compare
DawidWesierski4
requested review from
PanKaker,
Sakoram,
skolelis and
Falron98
as code owners
Sakoram
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPDK backend flow rules are failing on the E810 PF when ETH rules are ignored on
the default attribute group 0.
Flow rules are used to filter the data coming from queues, and by default,
attribute group 0 should be used. Applying the filters should not fail when the
flow validation function passes. However, this does not happen when we use
filters with the ETH segment set to NULL on E810 physical cards (it works fine
on the virtual NICs hosted on the same NIC).
Fix this problem for now by reapplying the flow rules when the verification
fails in this specific scenario.
This code should be deleted when the E810 PF NIC stops failing to apply
flow rules in this specific scenario.