Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: support for saving video to file in st20p #1017

Merged

Conversation

DawidWesierski4
Copy link
Collaborator

Add support for st20p RxTxApp video saving using
alraedy existing video url json parsing.

@DawidWesierski4
Copy link
Collaborator Author

(st20p && st20p->info.st20p_url will always be true, error in Ubuntu build tests

Objectively true, will change that

Add support for st20p RxTxApp video saving using
alraedy existing video url json parsing.
Copy link
Contributor

@MateuszGrabuszynski MateuszGrabuszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@skolelis
Copy link
Collaborator

skolelis commented Dec 6, 2024

LGTM

Copy link
Collaborator

@skolelis skolelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DawidWesierski4 DawidWesierski4 merged commit 353b64b into OpenVisualCloud:main Dec 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants