Fix: enable and fixing debug logging when 'debug' build type is used. #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DawidWesierski4 <[email protected]>
PanKaker
requested review from
DawidWesierski4,
Sakoram,
skolelis and
Falron98
as code owners
|
LGTM |
DawidWesierski4
approved these changes
Oct 28, 2024
small note it is kinda implied and i think not putting this in commit message is fine |
DawidWesierski4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduce fixing logging when DEBUG directive is used.
Debug also enabled when MTL is built with 'debug' flag, e.g.:
./build.sh debugonlyand
mtl_log_level log_levelset toMTL_LOG_LEVEL_DEBUGaccording tohttps://github.com/OpenVisualCloud/Media-Transport-Library/blob/main/doc/design.md#71-logging