fix clients leak

Signed-off-by: Ric Li <[email protected]>
OpenVisualCloud · Nov 16, 2023 · 698ed12 · 698ed12
1 parent 8e9a0f0
commit 698ed12
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/manager/logging.hpp b/manager/logging.hpp
@@ -21,7 +21,7 @@ class logger {
     }
   }
 
-  static void setlog_level(log_level level) { log_level_min = level; }
+  static void set_log_level(log_level level) { log_level_min = level; }
 
  private:
   static log_level log_level_min;

diff --git a/manager/mtl_manager.cpp b/manager/mtl_manager.cpp
@@ -25,7 +25,7 @@ int main() {
   std::vector<mtl_instance*> clients;
   std::shared_ptr<mtl_lcore> lcore_manager = std::make_shared<mtl_lcore>();
 
-  logger::setlog_level(log_level::INFO);
+  logger::set_log_level(log_level::INFO);
 
   fs::path directory_path(MTL_MANAGER_SOCK_PATH);
   directory_path.remove_filename();
@@ -180,12 +180,14 @@ int main() {
     }
   }
 
-  logger::log(log_level::INFO, "MTL Manager exited.");
-
 out:
-  clients.clear();
+  for (auto it = clients.begin(); it != clients.end(); ++it) {
+    delete *it;
+  }
   if (signal_fd >= 0) close(signal_fd);
   if (epfd >= 0) close(epfd);
   if (sockfd >= 0) close(sockfd);
+
+  logger::log(log_level::INFO, "MTL Manager exited.");
   return ret;
 }