Adress revew 2

OpenVisualCloud · Jan 7, 2025 · 697645f · 697645f
1 parent 2ca74ef
commit 697645f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/ecosystem/gstreamer_plugin/gst_mtl_st30p_rx.c b/ecosystem/gstreamer_plugin/gst_mtl_st30p_rx.c
@@ -256,15 +256,8 @@ static gboolean gst_mtl_st30p_rx_start(GstBaseSrc* basesrc) {
 
   /* mtl is already initialzied
   TODO: add support for initialization of multiple pipelines from one handle */
-  if (src->mtl_lib_handle) {
-    GST_INFO("Mtl already initialized");
-    if (mtl_start(src->mtl_lib_handle)) {
-      GST_ERROR("Failed to start MTL");
-      return FALSE;
-    }
-  } else {
+  if (!src->mtl_lib_handle) {
     strncpy(mtl_init_params.port[MTL_PORT_P], src->devArgs.port, MTL_PORT_MAX_LEN);
-
     ret = inet_pton(AF_INET, src->devArgs.local_ip_string,
                     mtl_init_params.sip_addr[MTL_PORT_P]);
     if (ret != 1) {
@@ -549,6 +542,7 @@ static gboolean gst_mtl_st30p_rx_negotiate(GstBaseSrc* basesrc) {
   ret = gst_pad_set_caps(GST_BASE_SRC_PAD(basesrc), caps);
   gst_caps_unref(caps);
   if (!ret) {
+    gst_audio_info_free(info);
     GST_ERROR("Failed to set caps");
     return FALSE;
   }

diff --git a/ecosystem/gstreamer_plugin/meson.build b/ecosystem/gstreamer_plugin/meson.build
@@ -22,7 +22,7 @@ plugin_c_args = [
   '-Wno-stringop-truncation'
 ]
 
-if run_command('test', '-d', '/usr/local/include/gstreamer-1.0').returncode() == 0
+if run_command('test', '-d', '/usr/local/include/gstreamer-1.0', check: false).returncode() == 0
     gstreamer_inc_dir = '/usr/local/include/gstreamer-1.0'
 else
     gstreamer_inc_dir = '/usr/include/gstreamer-1.0'