Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend custom service types in IP services #34

Merged

Conversation

vladhss
Copy link
Contributor

@vladhss vladhss commented Jul 31, 2024

No description provided.

@vladhss vladhss requested a review from a team as a code owner July 31, 2024 09:35
Copy link
Contributor

@sahaqaa sahaqaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sahaqaa
Copy link
Contributor

sahaqaa commented Jul 31, 2024

Manual tests ok:

1) resource_application.go
+ deploy all resources from example/applications.tf file
+ "terraform plan" (no drift)
+ update
+ destroy
+ import (no drift)

2) resource_service.go
+ deploy all resources from example/services.tf file
+ "terraform plan" (no drift)
+ update
+ destroy
+ import (no drift)

@sahaqaa sahaqaa merged commit 1a7892e into OpenVPN:main Jul 31, 2024
1 check passed
@vladhss vladhss deleted the feature/custom-service-types-in-services branch August 5, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants