Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added update method support for "cloudconnexa_connector" resource #19

Merged
merged 15 commits into from
Jul 26, 2024
Merged

Added update method support for "cloudconnexa_connector" resource #19

merged 15 commits into from
Jul 26, 2024

Conversation

michaelfmnk
Copy link
Contributor

No description provided.

@michaelfmnk
Copy link
Contributor Author

#12

@michaelfmnk michaelfmnk marked this pull request as ready for review July 26, 2024 11:18
@michaelfmnk michaelfmnk requested a review from a team as a code owner July 26, 2024 11:18
@michaelfmnk michaelfmnk requested a review from sahaqaa July 26, 2024 11:18
patoarvizu
patoarvizu approved these changes Jul 26, 2024
View reviewed changes
Copy link

@patoarvizu patoarvizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sahaqaa
Copy link
Contributor

sahaqaa commented Jul 26, 2024

Manual tests were done:

+ Create resources
cloudconnexa_network
cloudconnexa_connector

+ Read (Plan) - no drift should be detected
+ Update
+ Destroy

+ Compare output of datasource connector vs Swagger
// there are some differences, created backlog ticket internally

+ Compare output of datasource network vs Swagger
// there are some differences, created backlog ticket internally

+ Import and run plan -> no drift should be detected
cloudconnexa_network (not working, created backlog ticket internally)
cloudconnexa_connector (all OK)

sahaqaa
sahaqaa approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@sahaqaa sahaqaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sahaqaa sahaqaa merged commit 547fc7d into main Jul 26, 2024
1 check passed
@sahaqaa sahaqaa deleted the feature/update-connector branch July 26, 2024 15:57
@sahaqaa sahaqaa mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahaqaa sahaqaa sahaqaa approved these changes

@patoarvizu patoarvizu patoarvizu approved these changes

@arslanbekov arslanbekov arslanbekov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelfmnk @sahaqaa @arslanbekov @patoarvizu