Improve Makefile OS_ARCH variable #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Makefile we have next line:
When i need to make some changes to provider or to test some code i need to run "make" command. But for it to build proper version for me, i need to put manually "linux_amd64" in Makefile and doing this manually repeatedly seems like not the good idea.
Therefore i propose to change this line to:
$(shell go env GOHOSTOS) retrieves the operating system of the host machine.
$(shell go env GOHOSTARCH) retrieves the architecture of the host machine.
The combination
$(shell go env GOHOSTOS)_$(shell go env GOHOSTARCH)produces a string like darwin_arm64, linux_amd64, etc.This reduces the need for manual update of Makefile.