[TF] Improve resource "cloudconnexa_dns_record"

cloudconnexa/resource_dns_record.go

@@ -34,17 +34,22 @@ func resourceDnsRecord() *schema.Resource {
 				Description:  "The description for the UI. Defaults to `Managed by Terraform`.",
 			},
 			"ip_v4_addresses": {
-				Type:     schema.TypeList,
-				Optional: true,
+				Type:         schema.TypeList,
+				Optional:     true,
+				AtLeastOneOf: []string{"ip_v4_addresses", "ip_v6_addresses"},
+				MinItems:     1,
 				Elem: &schema.Schema{
+
 					Type:         schema.TypeString,
 					ValidateFunc: validation.IsIPv4Address,
 				},
 				Description: "The list of IPV4 addresses to which this record will resolve.",
 			},
 			"ip_v6_addresses": {
-				Type:     schema.TypeList,
-				Optional: true,
+				Type:         schema.TypeList,
+				Optional:     true,
+				AtLeastOneOf: []string{"ip_v4_addresses", "ip_v6_addresses"},
+				MinItems:     1,
 				Elem: &schema.Schema{
 					Type:         schema.TypeString,
 					ValidateFunc: validation.IsIPv6Address,

cloudconnexa/resource_dns_record_test.go

@@ -1,8 +1,10 @@
 package cloudconnexa
 
 import (
+	"errors"
 	"fmt"
 	"github.com/openvpn/cloudconnexa-go-client/v2/cloudconnexa"
+	"regexp"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
@@ -18,7 +20,7 @@ func TestAccCloudConnexaDnsRecord_basic(t *testing.T) {
 		CheckDestroy:      testAccCheckCloudConnexaDnsRecordDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCloudConnexaDnsRecordConfig(domainName),
+				Config: testAccCloudConnexaDnsRecordConfigWithoutIPs(domainName),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr(resourceName, "domain", domainName),
 					resource.TestCheckResourceAttr(resourceName, "description", "test description"),
@@ -32,6 +34,36 @@ func TestAccCloudConnexaDnsRecord_basic(t *testing.T) {
 	})
 }
 
+func TestAccCloudConnexaDnsRecord_noIPs(t *testing.T) {
+	expectedErr, _ := regexp.Compile("one of `ip_v4_addresses,ip_v6_addresses` must be specified")
+	domainName := "test.cloudconnexa.com"
+	resource.Test(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: testAccProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config:      testAccCloudConnexaDnsRecordConfigWithoutIPs(domainName),
+				ExpectError: expectedErr,
+			},
+		},
+	})
+}
+
+func TestAccCloudConnexaDnsRecord_IPsArrayIsEmpty(t *testing.T) {
+	expectedErr, _ := regexp.Compile("Attribute ip_v4_addresses requires 1 item minimum, but config has only 0")
+	domainName := "test.cloudconnexa.com"
+	resource.Test(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: testAccProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config:      testAccCloudConnexaDnsRecordConfigIPv4Empty(domainName),
+				ExpectError: expectedErr,
+			},
+		},
+	})
+}
+
 func testAccCheckCloudConnexaDnsRecordDestroy(s *terraform.State) error {
 	client := testAccProvider.Meta().(*cloudconnexa.Client)
 
@@ -43,8 +75,8 @@ func testAccCheckCloudConnexaDnsRecordDestroy(s *terraform.State) error {
 		recordId := rs.Primary.ID
 		r, err := client.DnsRecords.GetDnsRecord(recordId)
 
-		if err != nil {
-			return err
+		if !errors.Is(err, cloudconnexa.ErrDnsRecordNotFound) {
+			return nil
 		}
 
 		if r != nil {
@@ -69,3 +101,30 @@ resource "cloudconnexa_dns_record" "test" {
 }
 `, testCloudID, domainName)
 }
+
+func testAccCloudConnexaDnsRecordConfigWithoutIPs(domainName string) string {
+	return fmt.Sprintf(`
+provider "cloudconnexa" {
+  base_url = "https://%[1]s.api.openvpn.com"
+}
+
+resource "cloudconnexa_dns_record" "test" {
+  domain          = "%[2]s"
+  description     = "test description"
+}
+`, testCloudID, domainName)
+}
+
+func testAccCloudConnexaDnsRecordConfigIPv4Empty(domainName string) string {
+	return fmt.Sprintf(`
+provider "cloudconnexa" {
+  base_url = "https://%[1]s.api.openvpn.com"
+}
+
+resource "cloudconnexa_dns_record" "test" {
+  domain          = "%[2]s"
+  description     = "test description"
+  ip_v4_addresses = []
+}
+`, testCloudID, domainName)
+}