To be able to run OpenVPN client in Docker container #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file `/etc/resolv.conf` is not a regular one in Docker container, it is bind-mounts within container. It cause `cp: can't create '/etc/resolv.conf': File exists` error and as a result `resolv.conf.ovpnsave` is not copied back as it is intended. But rewriting the file instead of moving or renaming is possible.
|
this is a contrib script; normally not installed in any default $PATH. I consider these contrib scripts more like templates. Change itself is fine for me. |
|
@mtilson can we have your SoB line on the patch (preferably sent to the mailing list)? |
|
@mtilson any chance you could address the comments above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
/etc/resolv.confis not a regular one in Docker container, it is a bind-mount within container.It cause
cp: can't create '/etc/resolv.conf': File existserror and as a resultresolv.conf.ovpnsaveis not copied back as it is intended.But rewriting the file instead of moving or renaming is possible.