build-ca: Command 'req', remove SSL option '-keyout' #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL command 'req', option '-keyout' behaves differently between OpenSSL v3.x verses v1.x When the private key is encrypted: - v1.x ignores '-keyout' and does not create a new key. - v3.x creates a new key with different parameters to the original key. v3.x creates the original key, encrypted by AES-256-CBC; then creates the unnecessary, secondary key, encrypted by DES-EDE3-CBC. Because EasyRSA has already generated the private key, the 'req' command must not generate a secondary key. Signed-off-by: Richard T Bonhomme <[email protected]>
|
@ecrist This bug dates back to All versions of EasyRSA I think this change is suitable for EasyRSA If this is the only bug which comes to light for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL command 'req', option '-keyout' behaves differently between OpenSSL v3.x verses v1.x
When the private key is encrypted:
v3.x creates the original key, encrypted by AES-256-CBC; then creates the unnecessary, secondary key, encrypted by DES-EDE3-CBC.
Because EasyRSA has already generated the private key, the 'req' command must not generate a secondary key.