-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subject-Alt-Name: Correct behavior of global option --san #1093
Conversation
--san|--subject-alt-name current behavior is to append any value to EASYRSA_EXTRA_EXTS and repeatedly insert OpenSSL label 'subjectAltName'. This label should be specified once only. This change leaves EASYRSA_EXTRA_EXTS completely unchanged and outside of EasyRSA scope. This is done due to the lack of definition as to what EASYRSA_EXTRA_EXTS external definition is intended for. EASYRSA_EXTRA_EXTS is still used by command 'renew' but only for SAN. Create 'EASYRSA_SAN' for explicit subjectAltName use. This change correctly formats EASYRSA_SAN, to only begin with the label 'subjectAltName = ' and append user SAN values to that string. Example Command line: --san=DNS:server3 --san=DNS:swerveur3 --san=IP:10.2.2.2 --san=IP:10.1.1.1 --nopass build-server-full s3 Resulting certificate: X509v3 Subject Alternative Name: DNS:server3, DNS:swerveur3, IP Address:10.2.2.2, IP Address:10.1.1.1 The originally required command string: --san=DNS:server3,DNS:swerveur3,IP:10.2.2.2,IP:10.1.1.1 build-server-full s3 is also still supported. Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
If this PR is merged then the following are required:
Also, separating In short, the CA Admin must have ultimate control; Signed certificates must be allowed to change request details. For Easy-RSA, this currently only concerns the distinguished name and the annoying SAN. |
I must make this point clear: The last commit f6a6e75 was to remove default SAN. I stand by this decision because there is no RFC which clearly defines an alternate name. This PR is not going to be merged because something more drastic is required. This PR approach can still be used. However, use of |
Superseded-by: #1096 |
--san|--subject-alt-name
current behavior is to append any value toEASYRSA_EXTRA_EXTS
and repeatedly insert OpenSSL labelsubjectAltName
. This label should be specified once only.This change leaves
EASYRSA_EXTRA_EXTS
completely unchanged and outside of EasyRSA scope. This is done due to the lack of definition as to whatEASYRSA_EXTRA_EXTS
external definition is intended for.EASYRSA_EXTRA_EXTS
is still used by commandrenew
but only for SAN.Create
EASYRSA_SAN
for explicitsubjectAltName
use.This change correctly formats
EASYRSA_SAN
, to only begin with the labelsubjectAltName =
and append user SAN values to that string.Example Command line:
Resulting certificate:
The originally required command string:
is also still supported.