Skip to content

Commit

Permalink
sign-req: Remove default server 'subject alternative name' SAN
Browse files Browse the repository at this point in the history
Default SAN is removed from Easy-RSA.

The default SAN values provided by Easy-RSA are inadequate for purpose.

The default name is the same as 'commonName' and, therefore, not alternate.

The default IP address is a good example of "more is less".

Signed-off-by: Richard T Bonhomme <[email protected]>
  • Loading branch information
TinCanTech committed Mar 13, 2024
1 parent 6f45b81 commit 0b85a5d
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions easyrsa3/easyrsa
Original file line number Diff line number Diff line change
Expand Up @@ -2210,25 +2210,6 @@ basicConstraints is not defined, cannot use 'pathlen'"
unset -v ns_cert_type
esac

# If type is server and no subjectAltName was
# requested then add one to the extensions file
if [ -z "$EASYRSA_EXTRA_EXTS" ]; then
# default server SAN
case "$crt_type" in
server|serverClient)
# req san or default server SAN
__san="$(display_san req "$req_in")"
if [ "$__san" ]; then
__san="subjectAltName = $__san"
else
__san="$(default_server_san "$req_in")"
fi
[ "$__san" ] || die "No default server SAN!"
export EASYRSA_EXTRA_EXTS="$__san"
unset -v __san
esac
fi

# Generate the extensions file for this cert:
ext_tmp=""
easyrsa_mktemp ext_tmp || \
Expand Down

0 comments on commit 0b85a5d

Please sign in to comment.