Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser Rebuild #9

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Parser Rebuild #9

wants to merge 25 commits into from

Commits on Dec 11, 2023

  1. Initial rebuild/refactor of parsing code and corrections to tests 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    be25c48 View commit details
    Browse the repository at this point in the history

  2. Reshuffled module structure and created dedicated adapter.py entrypoint 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    a5da948 View commit details
    Browse the repository at this point in the history

  3. Optimization pass to match/beat performance of previous reader 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3cfdd3f View commit details
    Browse the repository at this point in the history

  4. SPLITs are now attached to following event, lint and cleanup pass 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    24d9d0a View commit details
    Browse the repository at this point in the history

  5. Added better handling around invalid timecodes 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    1fe6ba4 View commit details
    Browse the repository at this point in the history

  6. Fixed parsing for some edge case standard form lines 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    c54f18e View commit details
    Browse the repository at this point in the history

  7. More robustness for certain cases 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    276459f View commit details
    Browse the repository at this point in the history

  8. Added basic handling for EDLs in alternate encodings when using read_… 

    …from_file

Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    368ff00 View commit details
    Browse the repository at this point in the history

  9. Bumped to version 2.0.0.dev1 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    a8ff37e View commit details
    Browse the repository at this point in the history

  10. Now errors on some less common kinds of M2 effects 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    db7185e View commit details
    Browse the repository at this point in the history

  11. Fixed issue where commented out lines may be interpreted as something… 

    … other than a comment

Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    fd33371 View commit details
    Browse the repository at this point in the history

  12. Improved M2 effect handling for more cases 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0db2599 View commit details
    Browse the repository at this point in the history

  13. Added support for video events that overwrite previous events 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    b240127 View commit details
    Browse the repository at this point in the history

  14. Marked ignore_timecode_mismatch adapter arg deprecated 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    8b5de41 View commit details
    Browse the repository at this point in the history

  15. Fixed an issue where RationalTime might be created with Decimals inst… 

    …ead of floats

Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    dc03db4 View commit details
    Browse the repository at this point in the history

  16. Restored behavior where AX reel names are no longer persisted 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d983b92 View commit details
    Browse the repository at this point in the history

  17. Restored an EDL parse exception if an uhandled statement/directive is… 

    … given before clip parsing. This better flags non-edl files

Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    86b9157 View commit details
    Browse the repository at this point in the history

  18. Added feature to skip unsupported statements/do best effort parsing 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0b6f250 View commit details
    Browse the repository at this point in the history

  19. Updated to match old behavior of attaching locators to both sides of … 

    …a transition event

Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3af9b9c View commit details
    Browse the repository at this point in the history

  20. Added contextual data to EDLParserError where available 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    5e86a53 View commit details
    Browse the repository at this point in the history

  21. Linting pass 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3c29b1d View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Linting pass on tests 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    20c01a9 View commit details
    Browse the repository at this point in the history

  2. One more lint fix 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    87b27e0 View commit details
    Browse the repository at this point in the history

  3. Added cached_property backward compatability 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    1aa7492 View commit details
    Browse the repository at this point in the history

  4. Made tests avoid children_if to avoid OTIO version dependence 

    Signed-off-by: Eric Reinecke <[email protected]>
    @reinecke
    reinecke committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    2077f17 View commit details
    Browse the repository at this point in the history