Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and always center platform cards #70

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Cleanup and always center platform cards #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b43d09f
Convert platform card to liquid template
X9VoiD Nov 28, 2023
a07a9cf
Use flex to always center cards
X9VoiD Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions _includes/platformcard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{% assign imageSize = 175 %}

{% capture platformInstall %}
_wiki/Install/{{ include.platform }}.md
{% endcapture %}

{% capture platformFAQ %}
_wiki/FAQ/{{ include.platform }}.md
{% endcapture %}

<div class="card m-3" style="max-width: 20em; flex: 1 0 100%">
<div class="card-header">
<h4 class="pt-2 text-center">{{ include.platform }}</h4>
</div>
<div class="d-flex justify-content-center">
<img class="pt-4 pb-2" height="{{ imageSize }}" src="{{ include.platformImage }}"/>
</div>
<div class="card-body d-flex flex-column mx-1">
<a class="btn btn-primary my-1" href="{{ platformInstall }}">
Installation Guide
</a>
<a class="btn btn-secondary my-1" href="{{ platformFAQ }}">
FAQ
</a>
</div>
</div>
78 changes: 20 additions & 58 deletions _includes/platformcards.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,60 +1,22 @@
{% assign imageSize = 175 %}
<div class="container d-flex flex-wrap mb-3 justify-content-center">
{% capture platformImage %}
{% link assets/images/platform/Windows_logo_-_2012_derivative.svg %}
{% endcapture %}
{% include platformcard.html
platform="Windows"
platformImage=platformImage %}

<div class="container mb-3">
<div class="row row-cols-1 row-cols-md-2 row-cols-xl-3 g-3">
<div class="col">
<div class="card">
<div class="card-header">
<h4 class="pt-2 text-center">Windows</h4>
</div>
<div class="d-flex justify-content-center">
<img class="pt-4 pb-2" height="{{ imageSize }}" src="{% link assets/images/platform/Windows_logo_-_2012_derivative.svg %}"/>
</div>
<div class="card-body d-flex flex-column mx-1">
<a class="btn btn-primary my-1" href="{% link _wiki/Install/Windows.md %}">
Installation Guide
</a>
<a class="btn btn-secondary my-1" href="{% link _wiki/FAQ/Windows.md %}">
FAQ
</a>
</div>
</div>
</div>
<div class="col">
<div class="card">
<div class="card-header">
<h4 class="pt-2 text-center">Linux</h4>
</div>
<div class="d-flex justify-content-center">
<img class="pt-4 pb-2" height="{{ imageSize }}" src="{% link assets/images/platform/TuxFlat.svg %}"/>
</div>
<div class="card-body d-flex flex-column mx-1">
<a class="btn btn-primary my-1" href="{% link _wiki/Install/Linux.md %}">
Installation Guide
</a>
<a class="btn btn-secondary my-1" href="{% link _wiki/FAQ/Linux.md %}">
FAQ
</a>
</div>
</div>
</div>
<div class="col">
<div class="card">
<div class="card-header">
<h4 class="pt-2 text-center">MacOS</h4>
</div>
<div class="d-flex justify-content-center">
<img class="pt-4 pb-2" height="{{ imageSize }}" src="{% link assets/images/platform/Apple_Computer_Logo_rainbow.svg %}"/>
</div>
<div class="card-body d-flex flex-column mx-1">
<a class="btn btn-primary my-1" href="{% link _wiki/Install/MacOS.md %}">
Installation Guide
</a>
<a class="btn btn-secondary my-1" href="{% link _wiki/FAQ/MacOS.md %}">
FAQ
</a>
</div>
</div>
</div>
</div>
{% capture platformImage %}
{% link assets/images/platform/TuxFlat.svg %}
{% endcapture %}
{% include platformcard.html
platform="Linux"
platformImage=platformImage %}

{% capture platformImage %}
{% link assets/images/platform/Apple_Computer_Logo_rainbow.svg %}
{% endcapture %}
{% include platformcard.html
platform="MacOS"
platformImage=platformImage %}
</div>
Comment on lines +16 to +21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't care about keeping {% link %} usage intact (as solving #67 will make sure we can't use bad paths) the 3 repetitions can be done over a data object (e.g. /_data/os.json) instead.

Loading