Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of RAID to smart-stats.py. Closes OpenTSDB/tcollector#232 #233

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sanblch
Copy link

@sanblch sanblch commented Jan 18, 2016

#232 #233

  1. It selects working drives by common method and then by smartmontools.
glob.glob(\"/dev/[hs]d[a-z]{1,2}\")
smartctl --scan-open
  1. It writes normalized smart values also.
  2. It gives 2 variants of naming smart variables: by number and by real name.
  3. It is able to get smart data from megaraid arrays by means of smartmontools.
  4. It checks serial number and deletes duplicated devices according to priority above.

@sanblch
Copy link
Author

sanblch commented Jan 18, 2016

Hi! Check, please. Everything works fine for me. It is more robust to define disk drives as it uses 'smartctl --scan-open' command. And then check each drive by its type. It need additional fixes of coarse. If you like it, I'll make more changes.

@johann8384
Copy link
Member

I'll start testing this, can you confirm you have completed the CLA?

@sanblch
Copy link
Author

sanblch commented Jan 26, 2016

Thanks for you collaboration, I've completed it.

@johann8384 johann8384 added this to the 1.3.1 milestone Feb 16, 2016
@johann8384 johann8384 modified the milestones: 1.3.1, 1.3.2 Mar 16, 2016
@@ -1,4 +1,4 @@
#! /usr/bin/env python
#! /usr/bin/python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets leave this "env python"

@johann8384 johann8384 modified the milestones: 1.3.3, 1.3.2 Sep 14, 2016
@johann8384 johann8384 modified the milestones: 1.3.3, 1.3.4 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants