Add support for passing parameters to imwrite() #225
Conversation
|
Force-pushed my commit with the auto-fixes merged. |
stitching/cli/stitch.py
Outdated
| @@ -263,6 +263,13 @@ def create_parser(): | |||
| choices=Timelapser.TIMELAPSE_CHOICES, | |||
| type=str, | |||
| ) | |||
| parser.add_argument( | |||
There was a problem hiding this comment.
I would like to call it output_params and put it after --output to have a closer connection here.
I would like to extend the help a bit. Maybe just describe your example, how cv.IMWRITE_TIFF_COMPRESSION, cv.IMWRITE_TIFF_COMPRESSION_NONE leads to 259 1 (the integers to be used in the CLI)
stitching/cli/stitch.py
Outdated
| @@ -295,6 +302,9 @@ def main(): | |||
| preview = args_dict.pop("preview") | |||
| output = args_dict.pop("output") | |||
|
|
|||
There was a problem hiding this comment.
name this output_params and put it directly below output, we don't need the comment
There was a problem hiding this comment.
You can use output_params = args_dict.pop("output_params", [])
It removes the param from the dict since stitcher dont accept it. If its not there we use an empty list
There was a problem hiding this comment.
But I dont know If output_params is not in the dict (then it would work) or None (then it would not work)
There was a problem hiding this comment.
We should just set an empty list as Default as its done with the Feature masks:
parser.add_argument(
"--feature_masks",
nargs="*",
default=[],
help="Masks for selecting where features should be detected.",
type=str,
)
stitching/stitcher.py
Outdated
| @@ -44,6 +44,7 @@ class Stitcher: | |||
| "blend_strength": Blender.DEFAULT_BLEND_STRENGTH, | |||
| "timelapse": Timelapser.DEFAULT_TIMELAPSE, | |||
| "timelapse_prefix": Timelapser.DEFAULT_TIMELAPSE_PREFIX, | |||
| "imwrite_params": None, | |||
There was a problem hiding this comment.
we don't need this since stitcher never calls imwrite
|
Thanks for the feedback @lukasalexanderweber. I've made all the requested changes and force-pushed my commit. Hopefully the help text makes sense. |
stitching/cli/stitch.py
Outdated
| @@ -294,6 +309,7 @@ def main(): | |||
| verbose_dir = args_dict.pop("verbose_dir") | |||
| preview = args_dict.pop("preview") | |||
| output = args_dict.pop("output") | |||
| output_params = args_dict.pop("output_params", []) | |||
There was a problem hiding this comment.
You can remove the empty list here, since its already the default in the argument parser
There was a problem hiding this comment.
Done! (force pushed)
Great! Yea I had the same thought about the length of the help string. But it has the potential to be confusing, so it's probably worth a little more verbosity in this particular case. :-) |
|
Thank you for your contribution and also very much for your donation over opencollective! :) it was the very first one and put a big smile on my face :) |
|
Thank you for making and maintaining this project! :-) |
This adds a new CLI argument for passing parameters into OpenCV's
imwrite()function.This allows, among other things, to customize compression of the output image file. For example, currently a TIFF will always be output with LZW compression as a default. This allows exporting uncompressed TIFFs. JPEG quality can also be configured.
For the full list of
imwrite()parameters, see: https://docs.opencv.org/4.10.0/d8/d6a/group__imgcodecs__flags.htmlSee related discussion for more detail: #224
Starting this as a "draft" pull request so that we can see if tests pass, and determine if anything else is necessary.